files with whitespaces as start won't work via fish

[Patrick Winnertz <winnie@…>]

Hey,

Currently it is not possible to do any action on a file which starts white a
whitespace.
I fixed the issue in Debian with a patch which adds quotes around every file.

This works very well.. the drawback is that the -Q option for ls is not a
standard and is only used on linux hosts.
Therefore this patch has to be changed slightly to do not fail on non-linux
hosts. This patch needs two functions which are introduced in #147, therefore
we need to solve this ticket before this one can be solved.

This patch won't apply on mc-4.6 I guess as it was written for an earlier
version of mc. I'll update it afterwards.

Greetings
Winnie

[Patrick Winnertz]

Added by email2trac

[Patrick Winnertz]

This message has 1 attachment(s)

[Patrick Winnertz]

Sadly it's not possible to set the stuff without writing a bit or in the first
mail:

I'll work on this and this should be fixe in 4.6.2.

[winnie]

(In #10) There is a fix in the 10_fish_stalls_on_symlink branch.. however this fix is uncomplete as it will fail in this scenario:

echo "ALL OK" >"this -> file"
ln -s "this -> file" "this -> link"

The link will point to -> file instead of "this -> file".

To fix this issue we need quoted output. (This means ls -Q). As this is no standard option but only used in gnu ls we have to check prior using it if this option is available.
However this is related to ticket:149.

[winnie]

(In #147) remove #149 as blocked bug as #149 needs only the escaping functions which are now provides by the mhl lib which was added in #157

[slyfox]

vfs/fish.c: All escaping stuff was overhauled. The current idea is not to use quotes, but use proper shell escaping (quotes break ls for example, it can't parse something like this: ls " a-> b\"\"\"").

All fish ops(chown, rmdir, rm, stor, retr) were converted to use <mhl/escape.h>, removed escape nesting.

Current patchset is at branch:10_fish_whitespace_symlink_issue

Please review and test!

[Patrick Winnertz]

Added by email2trac

[Patrick Winnertz]

Hey,

I've rebased that branch and created a diff. Please review, test and vote.

for those who are not that familiar with git I've added the diff between the
branch and mc-4.6 so that you'll can see what will change.

[winnie]

Committed