Ticket #1487 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Option Whole words in Find, Editor

Reported by: dborca Owned by: angel_il
Priority: major Milestone: 4.7.0-pre2
Component: mc-core Version: 4.7.0-pre1
Keywords: whole words Cc: dborca@…, dmartina@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

There are a few things which came with the new search engine:

  1. A bug in src/search/regex.c prevents using \b in regex search. There's a duplicate of \B.
  2. There's no "Whole Words Only" option. One could use regex search with \btext\b, but see the bug above. Besides, it would be nice to have a quick "Whole Words Only" checkbox for text searches. I sometimes find it useful, even in File Find (a la "grep -rw").

Attachments

mc-4.7.0-pre1.search.patch.gz (3.5 KB) - added by dborca 9 years ago.
mc-4.7.0-pre1.search.patch (16.3 KB) - added by angel_il 9 years ago.
find.c.patch (430 bytes) - added by dmartina 9 years ago.
Missing runtime i18n of new "First Hit" label

Change History

Changed 9 years ago by dborca

comment:1 Changed 9 years ago by dborca

  • Cc dborca@… added

comment:2 Changed 9 years ago by andrew_b

Pleas split your patch to several independent parts and reopen the according tickets.
And again, please don't attach gzip'ed patches.

Changed 9 years ago by angel_il

comment:3 Changed 9 years ago by dmartina

  • Cc dmartina@… added
  • Blocking 1370 added

Be careful with i18n! See patch about "First hit".

Changed 9 years ago by dmartina

Missing runtime i18n of new "First Hit" label

comment:4 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:5 Changed 9 years ago by andrew_b

Find file bugs are fixed in reopened #1457. See http://www.midnight-commander.org/ticket/1457#comment:17

comment:6 Changed 9 years ago by dmartina

  • Blocking 1370 removed

"First hit" does translate.

comment:7 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre2

comment:8 Changed 9 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:9 Changed 9 years ago by angel_il

  • Description modified (diff)

comment:10 Changed 9 years ago by angel_il

  • Keywords whole words added

branch 1487_whole_words (parent: master)
changeset: 14d668dcf33d2db5eff58c9b98442810586b8235

comment:11 Changed 9 years ago by angel_il

  • severity changed from no branch to on review

comment:12 Changed 9 years ago by angel_il

  • Summary changed from Search improvements/bugfixes in Find, Editor, View to Option Whole words in Find, Editor

comment:13 Changed 9 years ago by angel_il

changeset: 156b79609cb58cf99ca27b25498308d493a016ee (forced update)

comment:14 Changed 9 years ago by andrew_b

  • Blocking 1560 added

comment:14 Changed 9 years ago by iNode

  • Votes for changeset set to iNode
  • Blocking 1560 removed

Looks good.

comment:15 Changed 9 years ago by iNode

  • Blocking 1560 added

comment:16 Changed 9 years ago by andrew_b

  • Votes for changeset changed from iNode to iNode andrew_b
  • severity changed from on review to approved

comment:17 Changed 9 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from iNode andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:18 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
  • Description modified (diff)

comment:19 Changed 9 years ago by andrew_b

  • Blocking 1560 removed
Note: See TracTickets for help on using tickets.