Ticket #1481 (closed defect: duplicate)

Opened 9 years ago

Last modified 9 years ago

Backward Kill Word in widgets

Reported by: dborca Owned by: angel_il
Priority: major Milestone:
Component: mc-core Version:
Keywords: Cc: dborca@…, egmont@…
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

The Backward Kill Word does not work correctly in widgets. For example, M-Backspace on "patch.gz" will result in "patch", whereas it should give "patch." <-- note the trailing dot.

Attached patch (against 4.7.0-pre1) fixes this. Maybe :)

Attachments

mc-4.7.0-pre1.back_word.patch.gz (356 bytes) - added by dborca 9 years ago.
mc-4.7.0-pre1.back_word.patch (824 bytes) - added by angel_il 9 years ago.

Change History

Changed 9 years ago by dborca

comment:1 Changed 9 years ago by dborca

  • Cc dborca@… added

comment:2 Changed 9 years ago by slavazanko

stay in pre2

Changed 9 years ago by angel_il

comment:3 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:4 Changed 9 years ago by iNode

  • Blocked By 256 added

(In #256) #1481 seems to be related or the same bug.

comment:5 Changed 9 years ago by egmont

I don't think this patch is correct. It contains "str_isspace (p - 1)" and such, whereas p points to the start of a character, so p-1 might point to the middle of a UTF-8 sequence. You should step backwards by a whole character, not 1 byte.

How about the patch in bug #256?

comment:6 Changed 9 years ago by egmont

  • Cc egmont@… added

comment:7 Changed 9 years ago by angel_il

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

need check after fix #256

comment:8 Changed 9 years ago by iNode

  • Blocked By 256 removed

(In #256) Ok, I close this as duplicate to cleanup roadmap.

comment:9 Changed 9 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:10 Changed 9 years ago by angel_il

  • Status changed from accepted to testing
  • Resolution set to duplicate

comment:11 Changed 9 years ago by slavazanko

  • Status changed from testing to closed

comment:12 Changed 9 years ago by slavazanko

  • Version 4.7.0-pre1 deleted
  • Milestone 4.7.0-pre4 deleted
Note: See TracTickets for help on using tickets.