capability to remove history items wanted

[iNode]

Any history items in history list should be deleted by
C-d/Del, and C-l should clean whole history list.

[andrew_b]

Created 1445_remove_history_items branch. Parent branch: master.
Initial changeset:a8d490de07601ab89345b9ccede4c5451abb5e3f

[andrew_b]

Rebased to current master.
changeset:1dc199b5f1a3207b529468e68ca5fedb93944eea

[iNode]

Good work, thanks.

Isn't it should be repainted after element delete?
(i.e. when you delete last item, previous should be last in list widget, instead of new empty line)

Also, C-l behaviour not implemented.

[andrew_b]

Replying to iNode:

Good work, thanks.

:)

Isn't it should be repainted after element delete?
(i.e. when you delete last item, previous should be last in list widget, instead of new empty line)

OK. I'll try to fix that.

Also, C-l behaviour not implemented.

C-l is used to repaint the screen. We should find another shortcut. Maybe Shift-Del?

Also, I think the confirmaton of list clean is needed (or even confirmation of a single item removal).

[iNode]

Yes, I'm agree either with confirmation dialog need and alternative (customizable?) shortcut.
Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

[andrew_b]

Replying to iNode:

Yes, I'm agree either with confirmation dialog need

Confirmation of what? Clean of whole list or delete of a single list item?

and alternative (customizable?) shortcut. Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

Keybindings for WListbox widget are not implemented yet and should be implemented ASAP.

[iNode]

Confirmation for whole list cleanup.

Replying to andrew_b:

Replying to iNode:

Yes, I'm agree either with confirmation dialog need

Confirmation of what? Clean of whole list or delete of a single list item?

and alternative (customizable?) shortcut. Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

Keybindings for WListbox widget are not implemented yet and should be implemented ASAP.

[andrew_b]

Fixed:

• keybindings: d or Del to remove current item of history; D or Shift-Del to clean the history;
• list scrolling if last item is deleted;
• cleanup history confirmation;

Initlial changeset:2470831648751d2776392f124c8adb83895d8a3d
Please review.

[iNode]

Confirm 1 and 3, second - behaviour not changed.

$ mc -V
GNU Midnight Commander 4.7.0.1-176-gf00ff08

May be we talk about another things? When delete last (or any other line),
list widget should be correctly scrolled, but now it just shift another items up.

Example:
ls
cd
rm -rf
<empty line>

After delete (on cd):
ls
rm -rf
<empty line>
<empty line>

After delete on rm -rf:
ls
<empty line>
<empty line>
<empty line>

Should be:
ls
<empty line>

[iNode]

Ok, thanks for all changes. Now it works properly.

[andrew_b]

Merged to master.
changeset:1ebdf5df0aa560a8ca64bcd6762d8c72d62692ee

[andrew_b]

changeset:7b9226c5da3a81fb758bee70aafe05bb64d37464 (#2068) must be cherry-picked to 4.7.0-stable after cherry-pick of this ticket feature.

[andrew_b]

#2299 fixes history show.

[andrew_b]

Cherry-picked to 4.7.0-stable with #2068 and #2299 fixes:
changeset:e8db5f88d273992c2d7720414ac5da454b643304
Initial changeset:47a806aea603166eec70692d0c7fddbd34207751