Ticket #1437 (closed defect: fixed)

Opened 15 years ago

Last modified 13 years ago

[RPMLint] script-related warnings

Reported by: zaytsev Owned by: andrew_b
Priority: minor Milestone: 4.8.4
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

I have conducted an audit of the current SPEC file with RPMLint and here are the significant errors it finds at the moment.

As far as I understand, we need to add shebangs in some cases, in some cases remove them and in some cases reconsider permissions.

These are not critical errors, just recommended best practices.

mc.i386: E: executable-sourced-script /etc/profile.d/mc.sh 0755                                                               
mc.i386: E: executable-sourced-script /etc/profile.d/mc.csh 0755                                                              
                                                                                                                              
This text file has executable bit set, but is meant to be sourced, not                                                        
executed.                                                                                                                     
                                                                                                                              
mc.i386: E: non-executable-script /etc/mc/edit.indent.rc 0644 /bin/sh                                                         
mc.i386: E: non-executable-script /etc/mc/edit.spell.rc 0644 /bin/sh                                                          
                                                                                                                              
This text file contains a shebang or is located in a path dedicated for                                                       
executables, but lacks the executable bits and cannot thus be executed.  If                                                   
the file is meant to be an executable script, add the executable bits,                                                        
otherwise remove the shebang or move the file elsewhere.                                                                      
                                                                                                                              
mc.i386: E: script-without-shebang /usr/libexec/mc/mc.csh                                                                     
mc.i386: E: script-without-shebang /usr/libexec/mc/mc.sh                                                                      
mc.i386: E: script-without-shebang /usr/libexec/mc/mc-wrapper.sh                                                              
mc.i386: E: script-without-shebang /usr/libexec/mc/mc-wrapper.csh                                                             
                                                                                                                              
This text file has executable bits set or is located in a path dedicated for                                                  
executables, but lacks a shebang and cannot thus be executed.  If the file is                                                 
meant to be an executable script, add the shebang, otherwise remove the                                                       
executable bits or move the file elsewhere.

Attachments

mc-4.8.3-4.cfg_scripts.patch​ (759 bytes) - added by szaszg 13 years ago.

Change History

comment:1 Changed 15 years ago by angel_il

  • Milestone changed from 4.7.0-pre2 to 4.7

comment:2 Changed 13 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

Changed 13 years ago by szaszg

comment:3 Changed 13 years ago by szaszg

edit.indent.rc and edit.spell.rc scripts should be installed as script not as data files (in misc/makefile.am scr_DATA -> scr_SCRIPTS). Patch attached.

comment:4 Changed 13 years ago by andrew_b

  • Status changed from new to accepted
  • Votes for changeset set to andrew_b
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.4
  • Keywords stable-candidate added

Thanks for the patch!

Branch: 1437_install_scripts (parent: master).
changeset:e58228016a6e7f67f4ce5f581e4933373d172747

comment:5 Changed 13 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • Branch state changed from on review to approved

comment:6 Changed 13 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to committed-master committed-stable
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [781378196ed26d7142e15033312d00e256f2639a].
Merged to 4.8.1-stable: [c0df27d288643235da6d7657f5fd815e3d8a398a].

comment:7 Changed 13 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.