Ticket #1422 (closed defect: fixed)
GNU specific options in buildsystem
| Reported by: | iNode | Owned by: | iNode |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre1 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | slyfox andrew_b |
Description (last modified by angel_il) (diff)
We should check buildsystem to be portable
Current issues (I will collect it here to fix in one patch)
version.sh
PREV_MC_VERSION=`sed -rn 's/^#define MC_CURRENT_VERSION "(.*)"$/\1/p' "${VERSION_FILE}"`
BSD sed has no "-r" optioin.
Attachments
Change History
Changed 15 years ago by iNode
- Attachment nongnused_version_sh.patch added
more portable solution instead of sed -r
comment:3 follow-up: ↓ 4 Changed 15 years ago by slavazanko
- Milestone changed from 4.7.0-pre2 to 4.7.0-pre1
May be, better to use:
- sed -rn 's/^#define MC_CURRENT_VERSION "(.*)"$/\1/p' "${VERSION_FILE}"
+ sed -n 's/^#define MC_CURRENT_VERSION "\(.*\)"$/\1/p' "${VERSION_FILE}"
Is perl availabe on any buildhosts?
And this critical bug for building of project. Therefore, need to fix as fast.
comment:4 in reply to: ↑ 3 Changed 15 years ago by iNode
Replying to slavazanko:
Is perl availabe on any buildhosts?
And this critical bug for building of project. Therefore, need to fix as fast.
The most of the hosts. Also vfs/fish and vfs/extfs and cedit.menu and so on
depends from perl. And we has another perl tools in /maint.
And yes, we can also use sed here. I'll update patch.
Is there any other issues like this?
comment:5 Changed 15 years ago by iNode
- Type changed from task to defect
- severity changed from no branch to on review
If threre is no other GNU specific issues, please vote.
comment:6 Changed 15 years ago by slyfox
- Votes for changeset set to slyfox
Looks good. I've pushed one fix too: changeset:1e94073c2d4e20582adbf66359986cad54290e74
comment:7 Changed 15 years ago by andrew_b
- Votes for changeset changed from slyfox to slyfox andrew_b
- severity changed from on review to approved
