Ticket #1422 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

GNU specific options in buildsystem

Reported by: iNode Owned by: iNode
Priority: major Milestone: 4.7.0-pre1
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: slyfox andrew_b

Description (last modified by angel_il) (diff)

We should check buildsystem to be portable

Current issues (I will collect it here to fix in one patch)
version.sh

PREV_MC_VERSION=`sed -rn 's/^#define MC_CURRENT_VERSION "(.*)"$/\1/p' "${VERSION_FILE}"` 


BSD sed has no "-r" optioin.

Attachments

nongnused_version_sh.patch (464 bytes) - added by iNode 10 years ago.
more portable solution instead of sed -r

Change History

comment:1 Changed 10 years ago by iNode

  • Status changed from new to accepted
  • Owner set to iNode

comment:2 Changed 10 years ago by angel_il

  • Description modified (diff)

Changed 10 years ago by iNode

more portable solution instead of sed -r

comment:3 follow-up: ↓ 4 Changed 10 years ago by slavazanko

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre1

May be, better to use:

- sed -rn 's/^#define MC_CURRENT_VERSION "(.*)"$/\1/p' "${VERSION_FILE}"
+ sed -n 's/^#define MC_CURRENT_VERSION "\(.*\)"$/\1/p' "${VERSION_FILE}"

Is perl availabe on any buildhosts?
And this critical bug for building of project. Therefore, need to fix as fast.

comment:4 in reply to: ↑ 3 Changed 10 years ago by iNode

Replying to slavazanko:

Is perl availabe on any buildhosts?
And this critical bug for building of project. Therefore, need to fix as fast.

The most of the hosts. Also vfs/fish and vfs/extfs and cedit.menu and so on
depends from perl. And we has another perl tools in /maint.

And yes, we can also use sed here. I'll update patch.

Is there any other issues like this?

comment:5 Changed 10 years ago by iNode

  • Type changed from task to defect
  • severity changed from no branch to on review

If threre is no other GNU specific issues, please vote.

changeset:2967f4434a86d3e2fc5dec7f644630ee2c539d05

comment:6 Changed 10 years ago by slyfox

  • Votes for changeset set to slyfox

Looks good. I've pushed one fix too: changeset:1e94073c2d4e20582adbf66359986cad54290e74

comment:7 Changed 10 years ago by andrew_b

  • Votes for changeset changed from slyfox to slyfox andrew_b
  • severity changed from on review to approved

comment:8 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.