Ticket #1421 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Memory leak in file_mask_dialog()

Reported by: andrew_b Owned by: andrew_b
Priority: critical Milestone: 4.7.0-pre1
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

There is a memory leak in file_mask_dialog() function.
The def_text_secure2 variable is not freed in the following place:

    if ((val = quick_dialog_skip (&Quick_input, SKIP)) == B_CANCEL) {
        g_free (def_text_secure);
        return 0;
    }

Change History

comment:1 Changed 10 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted

comment:2 Changed 10 years ago by andrew_b

  • severity changed from no branch to on review

Created 1421_file_mask_dialog_memleak branch. Parent branch: master.
changeset:353e316fc27738dc7313a01d2fca9f68b911426f

comment:3 Changed 10 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:4 Changed 10 years ago by iNode

  • Votes for changeset changed from slavazanko to slavazanko iNode
  • severity changed from on review to approved

Looks good. Thanks.

comment:5 Changed 10 years ago by andrew_b

  • Votes for changeset changed from slavazanko iNode to commited-master
  • severity changed from approved to merged

comment:6 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:7 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.