Ticket #130 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

FHS-Break: global config belongs into ${sysconfdir}/mc

Reported by: metux Owned by: slavazanko
Priority: minor Milestone: 4.7
Component: mc-core Version: 4.6.1
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slavazanko) (diff)

Lots of global config files (mc.ini, mc.menu*, mc.ext, ...) are currently installed @ ${datadir}/mc, but should go to ${sysconfdir}/mc.

commited into master: changeset:28539b236379ee31892ee54bdcc19502eae6149f

Attachments

mc-etcmc.patch (12.0 KB) - added by slavazanko 10 years ago.
Original patch from Fedora-10
mc-ru-fork_sysconfdir.patch (2.3 KB) - added by slavazanko 10 years ago.
Patch from russian fork. Fix installed directoryes by 'make install' command
global-config-into-sysconfdir-rev1.patch (13.2 KB) - added by slavazanko 10 years ago.
move global configs into ${sysconfdir}

Change History

Changed 10 years ago by slavazanko

Original patch from Fedora-10

Changed 10 years ago by slavazanko

Patch from russian fork. Fix installed directoryes by 'make install' command

Changed 10 years ago by slavazanko

move global configs into ${sysconfdir}

comment:1 Changed 10 years ago by slavazanko

See global-config-into-sysconfdir-rev1.patch.

This patch will agregate ideas from Fedora-10 and ru-mc-fork patches.

comment:2 Changed 10 years ago by slavazanko

  • Keywords review added

comment:3 Changed 10 years ago by slavazanko

Is 'HACK_install_dirs' branch relative to this ticket?

comment:4 Changed 10 years ago by Enrico Weigelt

  • MC Ticket System <tickets@…> schrieb:

Is 'HACK_install_dirs' branch relative to this ticket?

Yes, this the hacking branch for this.
But it still needs some cleanups.

comment:5 Changed 10 years ago by slavazanko

But it still needs some cleanups.

Is need to change keywords (remove 'review' and add 'cleanup')?
And what mean 'cleanups': refactoring(change intent/tabs/spaces) or some changes in logic?

comment:6 Changed 10 years ago by winnie

  • Milestone set to 4.7

comment:7 Changed 10 years ago by metux

  • Status changed from new to accepted
  • Owner set to metux

I've upated the HACK_install_branch. Please have a look at it.

comment:8 Changed 10 years ago by slavazanko

  • Owner changed from metux to slavazanko

created branch: 130_sysconfdir_mc (parent: master)

changeset:0c17219b2ab5cb5fe2e73f8d7cc9c11c755a3ae4

Now mc install global config files into sysconfdir; rpm-package from contrib/redhat/mc.spec builds; command make dist works correctly

Please, review and vote.

comment:9 Changed 10 years ago by slyfox

  • Keywords vote-slyfox added

Looks good. New layout is more intuitive.

comment:10 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b approved added; review removed

comment:11 Changed 10 years ago by slavazanko

  • Keywords commited-master added; vote-slyfox vote-andrew_b approved removed
  • Status changed from accepted to testing
  • Resolution set to fixed
  • Description modified (diff)

comment:12 Changed 10 years ago by styx

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.