savannah: copy from fish vfs stalls on symlinks

[slavazanko]

Original: ​http://savannah.gnu.org/bugs/?12972

Submitted by:	None	Submitted on:	Wed 04 May 2005 11:43:48 PM UTC
Category:	VFS	Severity:|3 - Normal
Status:	None	Privacy:	Public
Assigned to:	Pavel Tsekov <ptsekov>	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	GNU/Linux

Discussion:

Fri 06 May 2005 05:33:00 PM UTC, comment #3:

Symlinks to files. I don't think I had any problems with 
directories, now you come to mention it.

I did have sufficient permissions for the files: everything was 
world-readable.
	Anonymous
Thu 05 May 2005 01:05:11 PM UTC, comment #2:

I ask because I had experience with FISH similiar to the one 
described by the original poster. See this post:

http://mail.gnome.org/archives/mc-devel/2002-November/msg00067.html
	Pavel Tsekov <ptsekov>
Project AdministratorIn charge of this item.
Thu 05 May 2005 08:23:21 AM UTC, comment #1:

Symlinks to what ? A Directory, a file ? Have you checked that you 
have read permissions for the target of the symlink ?
	Pavel Tsekov <ptsekov>
Project AdministratorIn charge of this item.
Wed 04 May 2005 11:43:48 PM UTC, original submission:

Copying symlinks from Fish VFS freezes the UI.

This looks to be because the Fish VFS runs ls with -L (dereference 
symlinks) on the remote side and therefore only receives information
on the dereferenced files.

This includes the length of the file so MC stalls waiting for data 
when the remote host is reading the much smaller contents of the 
symlink.

[slavazanko]

Please, someone review and test patch fix-stalls-on-symlinks-rev1.patch

[winnie]

NACK from me..

S_ISLINK(ST.st_mode) exists... why don't use it.

BTW, this is a bugfix which is suitable for 4.6.2.. therefore Milestone 4.6.2

[Patrick Winnertz]

Added by email2trac

[Patrick Winnertz]

Updated patch now in order to use S_ISLNK and to do not fail on files or links
which are called: "foo -> bar".
Attached a rev2 of the patch (this is also viewable in
d65198e9f286acae8a9d9a9a7b499fe3328c3bcd ).

Please comment on this fix.

[Patrick Winnertz]

I've made a small update to this patch, as someone tries this in the past
without completing it.
There was a

case 'L': ent->ino->linkname = g_strdup(buffer+1);

but the ls command executed on the server never set a L<someinfo>, so this
code will never be executed.

Instead of setting a L<someinfo> line on the remote site via shell hacking, i
think it is more relyable to do this locally in c as we can't know which
commands are avialable on the remote site.

Please comment on this (rev3).

[Patrick Winnertz]

Added by email2trac

[slavazanko]

see test-fish-ls.sh

Script like this attach used for retrieve listing if remote directory. I will change script for run independ from mc and add some thinks... eg. check if ls support option '-Q'

[winnie]

There is a fix in the 10_fish_stalls_on_symlink branch.. however this fix is uncomplete as it will fail in this scenario:

echo "ALL OK" >"this -> file"
ln -s "this -> file" "this -> link"

The link will point to -> file instead of "this -> file".

To fix this issue we need quoted output. (This means ls -Q). As this is no standard option but only used in gnu ls we have to check prior using it if this option is available.
However this is related to ticket:149.

[ossi]

fwiw, kde's kio_fish can optionally use a perl-based stub which is faster and more reliable. given the availability of perl that might be more viable than special-casing shell code for more reliability.

[slavazanko]

I think, wee need to keep compability with really pure OSes (even don't have 'test' command).
In this case we may connect via fish to a lot of OSes... to my iPhone (without perl), fo example ;)

[Enrico Weigelt]

• MC Ticket System <tickets@…> schrieb:

fwiw, kde's kio_fish can optionally use a perl-based stub which is faster
and more reliable. given the availability of perl that might be more
viable than special-casing shell code for more reliability.

hmm. would of course require an test whether perl works and we
have some temporary working place on the server.

cu

[winnie]

removed #147 as blocking bug. the escape functions are now provided inside the mhl lib which was addressed in #157

[slyfox]

vfs/fish.c: Added perl backend, symlinks are properly showed as real symlinks (and copied the same way)

Current patchset is at branch:10_fish_whitespace_symlink_issue

Please review and test!

[Patrick Winnertz]

Hey,

Please review, test and votee on the patch in the branch (I've added the patch
also here in the email so that you can have a look on it

[Patrick Winnertz]

Added by email2trac

[styx]

connecting to just installed sshd on localhost