Ticket #3566: 3566-0002-Split-MSG_ACTION-into-MSG_ACTION-and-MSG_NOTIFY.patch

lib/widget/check.c

@@ -76 +76 @@
             return MSG_NOT_HANDLED;
         c->state ^= C_BOOL;
         c->state ^= C_CHANGE;
-        send_message (WIDGET (w)->owner, w, MSG_ACTION, 0, NULL);
+        send_message (WIDGET (w)->owner, w, MSG_NOTIFY, 0, NULL);
         send_message (w, sender, MSG_FOCUS, ' ', data);
         return MSG_HANDLED;
 

lib/widget/listbox.c

@@ -391 +391 @@
 listbox_on_change (WListbox * l)
 {
     listbox_draw (l, TRUE);
-    send_message (WIDGET (l)->owner, l, MSG_ACTION, l->pos, NULL);
+    send_message (WIDGET (l)->owner, l, MSG_NOTIFY, l->pos, NULL);
 }
 
 /* --------------------------------------------------------------------------------------------- */

lib/widget/radio.c

@@ -85 +85 @@
         {
         case ' ':
             r->sel = r->pos;
-            send_message (w->owner, w, MSG_ACTION, 0, NULL);
+            send_message (w->owner, w, MSG_NOTIFY, 0, NULL);
             send_message (w, sender, MSG_FOCUS, ' ', data);
             return MSG_HANDLED;
 
@@ -110 +110 @@
         }
 
     case MSG_CURSOR:
-        send_message (w->owner, w, MSG_ACTION, 0, NULL);
+        send_message (w->owner, w, MSG_NOTIFY, 0, NULL);
         send_message (w, sender, MSG_FOCUS, ' ', data);
         widget_move (r, r->pos, 1);
         return MSG_HANDLED;

lib/widget/widget-common.h

@@ -33 +33 @@
     MSG_HOTKEY_HANDLED,         /* A widget has got the hotkey */
     MSG_UNHANDLED_KEY,          /* Key that no widget handled */
     MSG_POST_KEY,               /* The key has been handled */
-    MSG_ACTION,                 /* Send to widget to handle command or
-                                 * state of check- and radiobuttons has changed
-                                 * and listbox current entry has changed */
+    MSG_ACTION,                 /* Send to widget to handle command */
+    MSG_NOTIFY,                 /* Typically sent to dialog to inform it of state-change
+                                 * of listboxes, check- and radiobuttons. */
     MSG_CURSOR,                 /* Sent to widget to position the cursor */
     MSG_IDLE,                   /* The idle state is active */
     MSG_RESIZE,                 /* Screen size has changed */

src/editor/editcmd.c

@@ -160 +160 @@
 {
     switch (msg)
     {
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         if (sender != NULL && sender->id == edit_save_mode_radio_id)
         {
             Widget *ww;

src/filemanager/boxes.c

@@ -129 +129 @@
 {
     switch (msg)
     {
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         /* message from "Single press" checkbutton */
         if (sender != NULL && sender->id == configure_old_esc_mode_id)
         {
@@ -306 +306 @@
         }
         return MSG_NOT_HANDLED;
 
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         if (sender != NULL && sender->id == panel_listing_types_id)
         {
             WCheck *ch;
@@ -427 +427 @@
 {
     switch (msg)
     {
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         /* message from "Always use ftp proxy" checkbutton */
         if (sender != NULL && sender->id == ftpfs_always_use_proxy_id)
         {

src/filemanager/chmod.c

@@ -220 +220 @@
 
     switch (msg)
     {
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         {
             /* handle checkboxes */
             int i;
 
-            /* close dialog due to SIGINT (ctrl-g) */
-            if (sender == NULL && parm == CK_Cancel)
-                return MSG_NOT_HANDLED;
-
-            /* whether action was sent by checkbox? */
+            /* whether notification was sent by checkbox? */
             for (i = 0; i < check_perm_num; i++)
                 if (sender == WIDGET (check_perm[i].check))
                     break;

src/filemanager/find.c

@@ -428 +428 @@
 
     switch (msg)
     {
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         if (sender == WIDGET (content_use_cbox))
         {
             gboolean disable = !(content_use_cbox->state & C_BOOL);

src/filemanager/hotlist.c

@@ -577 +577 @@
     switch (msg)
     {
     case MSG_INIT:
+    case MSG_NOTIFY:           /* MSG_NOTIFY is fired by the listbox to tell us the item has changed. */
         update_path_name ();
         return MSG_HANDLED;
 
@@ -593 +594 @@
         dlg_set_size (h, LINES - (h == hotlist_dlg ? 2 : 6), COLS - 6);
         return MSG_HANDLED;
 
-    case MSG_ACTION:
-        if (sender == NULL)
-            return MSG_NOT_HANDLED;
-
-        /* The listbox tells us the item has changed. */
-        update_path_name ();
-        return MSG_HANDLED;
-
     default:
         return dlg_default_callback (w, sender, msg, parm, data);
     }

src/filemanager/layout.c

@@ -371 +371 @@
         }
         return MSG_HANDLED;
 
-    case MSG_ACTION:
+    case MSG_NOTIFY:
         if (sender == WIDGET (radio_widget))
         {
             if (panels_layout.horizontal_split != radio_widget->sel)

src/filemanager/panelize.c

@@ -113 +113 @@
     switch (msg)
     {
     case MSG_INIT:
-        update_command ();
-        return MSG_HANDLED;
-
-    case MSG_ACTION:
-        if (sender == NULL)
-            return MSG_NOT_HANDLED;
-
-        /* The listbox tells us the item has changed. */
+    case MSG_NOTIFY:           /* MSG_NOTIFY is fired by the listbox to tell us the item has changed. */
         update_command ();
         return MSG_HANDLED;