Ticket #3269: mc-3269-use-meaningful-errno-or-0.patch

lib/event/event.c

@@ -54 +54 @@
 
     if (mc_event_grouplist != NULL)
     {
-        mc_propagate_error (mcerror, 1, "%s", _("Event system already initialized"));
+        mc_propagate_error (mcerror, 0, "%s", _("Event system already initialized"));
         return FALSE;
     }
 
@@ -64 +64 @@
 
     if (mc_event_grouplist == NULL)
     {
-        mc_propagate_error (mcerror, 2, "%s", _("Failed to initialize event system"));
+        mc_propagate_error (mcerror, 0, "%s", _("Failed to initialize event system"));
         return FALSE;
     }
 
@@ -80 +80 @@
 
     if (mc_event_grouplist == NULL)
     {
-        mc_propagate_error (mcerror, 3, "%s", _("Event system not initialized"));
+        mc_propagate_error (mcerror, 0, "%s", _("Event system not initialized"));
         return FALSE;
     }
 

lib/event/manage.c

@@ -74 +74 @@
     if (mc_event_grouplist == NULL || event_group_name == NULL || event_name == NULL
         || event_callback == NULL)
     {
-        mc_propagate_error (mcerror, 1, "%s", _("Check input data! Some of parameters are NULL!"));
+        mc_propagate_error (mcerror, 0, "%s", _("Check input data! Some of parameters are NULL!"));
         return FALSE;
     }
 
@@ -172 +172 @@
                              (GDestroyNotify) mc_event_group_destroy_value);
         if (event_group == NULL)
         {
-            mc_propagate_error (mcerror, 1, _("Unable to create group '%s' for events!"),
+            mc_propagate_error (mcerror, 0, _("Unable to create group '%s' for events!"),
                                 event_group_name);
             return NULL;
         }
@@ -197 +197 @@
         callbacks = g_ptr_array_new ();
         if (callbacks == NULL)
         {
-            mc_propagate_error (mcerror, 1, _("Unable to create event '%s'!"), event_name);
+            mc_propagate_error (mcerror, 0, _("Unable to create event '%s'!"), event_name);
             return NULL;
         }
         g_tree_insert (event_group, g_strdup (event_name), (gpointer) callbacks);

lib/serialize.c

@@ -110 +110 @@
 {
     if (data == NULL)
     {
-        g_set_error (error, MC_ERROR, -1, "mc_serialize_str(): Input data is NULL.");
+        g_set_error (error, MC_ERROR, 0, "mc_serialize_str(): Input data is NULL.");
         return NULL;
     }
     return g_strdup_printf ("%c%zd" SRLZ_DELIM_S "%s", prefix, strlen (data), data);
@@ -135 +135 @@
 
     if ((data == NULL) || (strlen (data) == 0))
     {
-        g_set_error (error, MC_ERROR, -1, FUNC_NAME ": Input data is NULL or empty.");
+        g_set_error (error, MC_ERROR, 0, FUNC_NAME ": Input data is NULL or empty.");
         return NULL;
     }
 
     if (*data != prefix)
     {
-        g_set_error (error, MC_ERROR, -2, FUNC_NAME ": String prefix doesn't equal to '%c'",
+        g_set_error (error, MC_ERROR, 0, FUNC_NAME ": String prefix doesn't equal to '%c'",
                      prefix);
         return NULL;
     }
@@ -154 +154 @@
         semi_ptr = strchr (data + 1, SRLZ_DELIM_C);
         if (semi_ptr == NULL)
         {
-            g_set_error (error, MC_ERROR, -3,
+            g_set_error (error, MC_ERROR, 0,
                          FUNC_NAME ": Length delimiter '%c' doesn't exists", SRLZ_DELIM_C);
             return NULL;
         }
         semi_offset = semi_ptr - (data + 1);
         if (semi_offset >= BUF_TINY)
         {
-            g_set_error (error, MC_ERROR, -3, FUNC_NAME ": Too big string length");
+            g_set_error (error, MC_ERROR, 0, FUNC_NAME ": Too big string length");
             return NULL;
         }
         strncpy (buffer, data + 1, semi_offset);
@@ -172 +172 @@
 
     if (data_len > strlen (data))
     {
-        g_set_error (error, MC_ERROR, -3,
+        g_set_error (error, MC_ERROR, 0,
                      FUNC_NAME
                      ": Specified data length (%zd) is greater than actual data length (%zd)",
                      data_len, strlen (data));

lib/vfs/path.c

@@ -1094 +1094 @@
 
     if ((vpath == NULL) || (vfs_path_elements_count (vpath) == 0))
     {
-        mc_propagate_error (mcerror, -1, "%s", "vpath object is empty");
+        mc_propagate_error (mcerror, 0, "%s", "vpath object is empty");
         return NULL;
 
     }
@@ -1177 +1177 @@
         {
             g_free (element);
             vfs_path_free (vpath);
-            g_set_error (mcerror, MC_ERROR, -1, "Unable to find VFS class by name '%s'", cfg_value);
+            g_set_error (mcerror, MC_ERROR, 0, "Unable to find VFS class by name '%s'", cfg_value);
             g_free (cfg_value);
             mc_config_deinit (cpath);
             return NULL;
@@ -1209 +1209 @@
     if (vfs_path_elements_count (vpath) == 0)
     {
         vfs_path_free (vpath);
-        g_set_error (mcerror, MC_ERROR, -1, "No any path elements found");
+        g_set_error (mcerror, MC_ERROR, 0, "No any path elements found");
         return NULL;
     }
     vpath->str = vfs_path_to_str_flags (vpath, 0, VPF_NONE);

src/filemanager/ext.c

@@ -648 +648 @@
         localfile_vpath = mc_getlocalcopy (filename_vpath);
         if (localfile_vpath == NULL)
         {
-            mc_propagate_error (mcerror, -1, _("Cannot fetch a local copy of %s"),
+            mc_propagate_error (mcerror, 0, _("Cannot fetch a local copy of %s"),
                                 vfs_path_as_str (filename_vpath));
             return FALSE;
         }
@@ -715 +715 @@
 
     if (got_data == -1)
     {
-        mc_propagate_error (mcerror, -1, "%s", _("Pipe failed"));
+        mc_propagate_error (mcerror, 0, "%s", _("Pipe failed"));
         return FALSE;
     }
 
@@ -733 +733 @@
         }
         else
         {
-            mc_propagate_error (mcerror, -1, "%s", _("Regular expression error"));
+            mc_propagate_error (mcerror, 0, "%s", _("Regular expression error"));
         }
     }
 

src/vfs/sftpfs/connection.c

@@ -75 +75 @@
 
     if (super->path_element->host == NULL || *super->path_element->host == '\0')
     {
-        mc_propagate_error (mcerror, -1, "%s", _("sftp: Invalid host name."));
+        mc_propagate_error (mcerror, 0, "%s", _("sftp: Invalid host name."));
         return -1;
     }
 
@@ -107 +107 @@
 
     if (e != 0)
     {
-        mc_propagate_error (mcerror, -1, _("sftp: %s"), gai_strerror (e));
+        mc_propagate_error (mcerror, 0, _("sftp: %s"), gai_strerror (e));
         my_socket = -1;
         goto ret;
     }
@@ -134 +134 @@
         close (my_socket);
 
         if (errno == EINTR && tty_got_interrupt ())
-            mc_propagate_error (mcerror, -1, "%s", _("sftp: connection interrupted by user"));
+            mc_propagate_error (mcerror, 0, "%s", _("sftp: connection interrupted by user"));
         else if (res->ai_next == NULL)
-            mc_propagate_error (mcerror, -1, _("sftp: connection to server failed: %s"),
+            mc_propagate_error (mcerror, 0, _("sftp: connection to server failed: %s"),
                                 unix_error_string (errno));
         else
             continue;
@@ -276 +276 @@
     g_free (p);
 
     if (passwd == NULL)
-        mc_propagate_error (mcerror, -1, "%s", _("sftp: Passphrase is empty."));
+        mc_propagate_error (mcerror, 0, "%s", _("sftp: Passphrase is empty."));
     else
     {
         ret_value = (libssh2_userauth_publickey_fromfile (super_data->session,
@@ -327 +327 @@
     g_free (p);
 
     if (passwd == NULL)
-        mc_propagate_error (mcerror, -1, "%s", _("sftp: Password is empty."));
+        mc_propagate_error (mcerror, 0, "%s", _("sftp: Password is empty."));
     else
     {
         while ((rc = libssh2_userauth_password (super_data->session, super->path_element->user,
@@ -387 +387 @@
     rc = libssh2_session_startup (super_data->session, super_data->socket_handle);
     if (rc != 0)
     {
-        mc_propagate_error (mcerror, -1, _("sftp: Failure establishing SSH session: (%d)"), rc);
+        mc_propagate_error (mcerror, 0, _("sftp: Failure establishing SSH session: (%d)"), rc);
         return (-1);
     }
 

src/vfs/sftpfs/file.c

@@ -248 +248 @@
 
     if (file_handler == NULL || file_handler->data == NULL)
     {
-        mc_propagate_error (mcerror, -1, "%s",
+        mc_propagate_error (mcerror, 0, "%s",
                             _("sftp: No file handler data present for reading file"));
         return -1;
     }