Ticket #4433 (new enhancement)

Opened 10 months ago

Last modified 10 months ago

Allow setting color for abnormal characters in editor from skin file

Reported by: ArtemKuchin Owned by:
Priority: minor Milestone: Future Releases
Component: mcedit Version: master
Keywords: color abnormal non printable skin Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by andrew_b) (diff)

in editdraw.c

/* If non-printable - use black background */
color = (style & MOD_ABNORMAL) != 0 ? 0 : p->style >> 16;

So, if, for example, file contains CR (M) i see a lot of M on black background tearing apart all my nice colors and poking my eyes out.
It would be nice to have something like editabnormal in skin file to set it to something noticeable but nice.

I tried adding it myself

skin.h

#define EDITOR_ABNORMAL_COLOR     mc_skin_color__cache[50]
#define MC_SKIN_COLOR_CACHE_COUNT 68

and renumbered cache array

colors.c

EDITOR_ABNORMAL_COLOR = mc_skin_color_get ("editor", "editabnormal");

editdraw.c

        else
            //tty_setcolor (EDITOR_ABNORMAL_COLOR);
            tty_lowlevel_setcolor (color);

But it does not work somehow. Compiles fine but just does not work. Abnormal chars just show as normal.

Attachments

editabnormal.diff (6.2 KB) - added by andrew_b 10 months ago.

Change History

comment:1 Changed 10 months ago by andrew_b

  • Description modified (diff)
  • Milestone changed from 4.8.29 to Future Releases

comment:2 Changed 10 months ago by ArtemKuchin

correct change i did is:

        else
            tty_setcolor (EDITOR_ABNORMAL_COLOR);
            //tty_lowlevel_setcolor (color);

It also broke syntax highlighting somehow. I am missing something.

comment:3 Changed 10 months ago by andrew_b

  • Description modified (diff)

Changed 10 months ago by andrew_b

comment:4 follow-up: ↓ 5 Changed 10 months ago by andrew_b

You should add the "editabnormal" color in the skin files. See the attached file.

comment:5 in reply to: ↑ 4 Changed 10 months ago by ArtemKuchin

Replying to andrew_b:

You should add the "editabnormal" color in the skin files. See the attached file.

Ah! Missed that. Thank you very much for the diff. Works great!

Note: See TracTickets for help on using tickets.