Ticket #4426 (closed task: fixed)

Opened 14 months ago

Last modified 7 months ago

Prepare for release mc-4.8.30

Reported by: zaytsev Owned by:
Priority: major Milestone: 4.8.30
Component: adm Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description


Attachments

mc-4357-file-remove-unused-variable.patch (1.4 KB) - added by zaytsev 14 months ago.
mc-4426-fix-implicit-function-declaration-warning.patch (1.1 KB) - added by and 12 months ago.
pr-164-add-dylib-support.patch (1.3 KB) - added by zaytsev 9 months ago.
pr-182-syntax-update-1.patch (847 bytes) - added by zaytsev 9 months ago.
pr-181-syntax-update-2.patch (713 bytes) - added by zaytsev 9 months ago.
pr-168.patch (1.3 KB) - added by zaytsev 9 months ago.
Screenshot 2023-08-07 at 17.24.07.png (162.2 KB) - added by zaytsev 7 months ago.

Change History

Changed 14 months ago by zaytsev

comment:1 Changed 13 months ago by andrew_b

comment:2 Changed 13 months ago by andrew_b

  • Version set to master

Merged to master: [8a91de70c4e7aba2dd01218c416f4135d049e1a4].

git log pretty=oneline a01fe3889..8a91de70c

comment:3 Changed 13 months ago by andrew_b

  • Blocking 4438 added

comment:4 Changed 12 months ago by andrew_b

mc-4426-fix-implicit-function-declaration-warning.patch​: applied.

Branch: 4426_cleanup
Initial changeset:728f5c1b0d5619b9599470b298b2198e899146b3

comment:5 Changed 12 months ago by andrew_b

Merge to master: [be3822cafab16519bf6934ebb594261c618080bb].

git log --pretty=oneline d845d0dc..be3822caf

comment:6 Changed 12 months ago by andrew_b

  • Blocking 4438 removed

comment:7 Changed 11 months ago by andrew_b

Last edited 9 months ago by andrew_b (previous) (diff)

Changed 9 months ago by zaytsev

comment:8 Changed 9 months ago by zaytsev

Added patch from closed GitHub? PR.

comment:9 Changed 9 months ago by andrew_b

pr-164-add-dylib-support.patch​: applied.

Changed 9 months ago by zaytsev

Changed 9 months ago by zaytsev

comment:10 Changed 9 months ago by zaytsev

Two more trivial patches from GitHub? added.

comment:11 Changed 9 months ago by andrew_b

pr-182-syntax-update-1.patch​: applied
pr-181-syntax-update-2.patch​: applied

comment:12 Changed 9 months ago by ukr

  • Blocked By 4467 added

comment:13 Changed 9 months ago by andrew_b

  • Blocked By 4467 removed

(In #4467) TL;DR.

Changed 9 months ago by zaytsev

comment:14 Changed 9 months ago by zaytsev

Added a patch from GitHub? to highlight *.zsh files as shell scripts.

comment:15 Changed 9 months ago by andrew_b

pr-168.patch​: applied.

comment:16 Changed 7 months ago by andrew_b

  • Votes for changeset set to committed-master

Merged to master: [04b37639a9139921cf26c766e361c9546ed14541].

git log --oneline 7111f8aa3..04b37639a

comment:17 follow-up: ↓ 19 Changed 7 months ago by zaytsev

Got two warnings during the build on master:

../../../lib/tty/color-internal.c: In function 'tty_color_get_name_by_index':
../../../lib/tty/color-internal.c:187:34: warning: '%d' directive writing between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=]
  187 |             sprintf (name, "color%d", idx);
      |                                  ^~
../../../lib/tty/color-internal.c:187:28: note: directive argument in the range [-2147483648, 255]
  187 |             sprintf (name, "color%d", idx);
      |                            ^~~~~~~~~
../../../lib/tty/color-internal.c:187:13: note: 'sprintf' output between 7 and 17 bytes into a destination of size 9
  187 |             sprintf (name, "color%d", idx);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../../../src/vfs/tar/tar-sparse.c: In function 'pax_decode_header':
../../../../src/vfs/tar/tar.c: In function 'tar_free_inode':
../../../../src/vfs/tar/tar.c:522:35: warning: unused parameter 'me' [-Wunused-parameter]
  522 | tar_free_inode (struct vfs_class *me, struct vfs_s_inode *ino)
      |                 ~~~~~~~~~~~~~~~~~~^~
../../../../src/vfs/tar/tar-sparse.c:697:50: warning: comparison of integer expressions of different signedness: '__off_t' {aka 'long int'} and 'long unsigned int' [-Wsign-compare]
  697 |                 || file->stat_info->stat.st_size < sp.offset + u)
      |   

comment:18 Changed 7 months ago by zaytsev

Built and pushed rc1 tarball. We really need to do something about Travis now :( noticed that CI hasn't been run since January...

comment:19 in reply to: ↑ 17 Changed 7 months ago by andrew_b

Replying to zaytsev:

Got two warnings during the build on master:

Will be fixed in the next cleanup after release.

Changed 7 months ago by zaytsev

comment:20 Changed 7 months ago by zaytsev

I've got reply from support and hopefully Travis builds will be working again, but now it complains about 1) warnings and 2) indentation. See screenshot.

comment:21 Changed 7 months ago by andrew_b

  CC       tar-sparse.lo
../../../../src/vfs/tar/tar-sparse.c: In function ‘pax_decode_header’:
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:156:6: note: in definition of macro ‘_GL_ADD_OVERFLOW’
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
      ^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro ‘_GL_INT_MINIMUM’
                       _GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)),         \
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:156:11: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
           ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:128:10: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
     ((b) < 0                                                            \
          ^
../../../../src/vfs/tar/tar-sparse.c:156:17: note: in expansion of macro ‘INT_ADD_RANGE_OVERFLOW’
    ((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max)                 \
                 ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:129:18: note: in definition of macro ‘INT_ADD_RANGE_OVERFLOW’
         ? (a) < (min) - (b)                                             \
                  ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro ‘_GL_INT_MINIMUM’
                       _GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)),         \
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
 #define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
                                                       ^
../../../../src/vfs/tar/tar-sparse.c:130:12: note: in definition of macro ‘INT_ADD_RANGE_OVERFLOW’
         : (max) - (b) < (a))
            ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:114:6: note: in expansion of macro ‘EXPR_SIGNED’
     (EXPR_SIGNED (e)                                                    \
      ^
../../../../src/vfs/tar/tar-sparse.c:125:23: note: in expansion of macro ‘_GL_INT_MAXIMUM’
                       _GL_INT_MAXIMUM (_GL_INT_CONVERT (a, b)))
                       ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW’
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
../../../../src/vfs/tar/tar-sparse.c:158:11: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
     : (b) < 0 ? (a) <= (a) + (b)                                        \
           ^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro ‘_GL_ADD_OVERFLOW’
   op_result_overflow (a, b,                                             \
   ^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro ‘_GL_BINARY_OP_OVERFLOW’
     _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
     ^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro ‘INT_ADD_OVERFLOW���
             if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u)
                                                                  ^
cc1: all warnings being treated as errors

I don't want modify the code from GNU tar and gnulib to pacify GCC. What about of use

#pragma GCC diagnostic ignored "-Wtype-limits"

in tar-sparse.c?

comment:22 Changed 7 months ago by zaytsev

Well, one could try to send a path to tar and gnulib people, but if you can't be bothered, then I think a pragma is OK to silence warnings for stolen code. If we start modifying it again, then updating will become more difficult... I think that it was quite a lot of work for you already to bring our tar implementation up to date.

comment:23 Changed 7 months ago by zaytsev

  • Status changed from new to closed
  • Resolution set to fixed

prepare repository for release
download PO-translations from Transifex
store translations in git repo
download the hint translations from Transifex
store translations in git repo

done

create new NEWS wiki page

NEWS-4.8.31

add content of current NEWS wiki page to the doc/NEWS
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files
make checksums for archives
upload source packages and checksums
run ssh midnightcommander@...
update Wiki start page with latest release number
write an announcement
close ticket for release
close current milestone

done

create new ticket

#4490

Note: See TracTickets for help on using tickets.