Ticket #4397 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

sort in editor (ALT-T) without arguments stopped working

Reported by: sxmboer2 Owned by: andrew_b
Priority: major Milestone: 4.8.29
Component: mcedit Version: master
Keywords: sort editor Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

In the editor, select a block of text and hit ALT-T does nothing when the argument is empty.
when options are used, e.g. "+0", "-r", "-u", sorting works fine.

midnightcommander>LC_MESSAGES=C ./src/mc -V
GNU Midnight Commander 4.8.28-72-g255502756
Built with GLib 2.70.4
Built with S-Lang 2.3.2 with terminfo database
Built with libssh2 1.10.0
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;
midnightcommander>LC_MESSAGES=C ./src/mc -F
Home directory: /root
Profile root directory: /root

[System data]
    Config directory: /usr/local/etc/mc/
    Data directory:   /usr/local/share/mc/
    File extension handlers: /usr/local/libexec/mc/ext.d/
    VFS plugins and scripts: /usr/local/libexec/mc/
	extfs.d:        /usr/local/libexec/mc/extfs.d/
	fish:           /usr/local/libexec/mc/fish/

[User data]
    Config directory: /root/.config/mc/
    Data directory:   /root/.local/share/mc/
	skins:          /root/.local/share/mc/skins/
	extfs.d:        /root/.local/share/mc/extfs.d/
	fish:           /root/.local/share/mc/fish/
	mcedit macros:  /root/.local/share/mc/mc.macros
	mcedit external macros: /root/.local/share/mc/mcedit/macros.d/macro.*
    Cache directory:  /root/.cache/mc/
midnightcommander>src/mc --configure-options
 'PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig:/usr/local/share/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Change History

comment:1 Changed 2 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Description modified (diff)
  • Milestone changed from Future Releases to 4.8.29

comment:2 Changed 2 years ago by andrew_b

  • Branch state changed from no branch to on review

Thanks for the bugreport!

Branch: 4397_winput_api_fixes
Initial changeset:318315399b366dadd3a36da410d70df42ee09e0a

comment:3 Changed 2 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 2 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [0b86047c8106f87d1fc8ed3a3adde3ac5b66b659].

git log --pretty=oneline 9f15305dc..0b86047c8

comment:5 Changed 2 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.