Ticket #4270 (closed task: fixed)

Opened 9 months ago

Last modified 8 weeks ago

Prepare for release mc-4.8.28

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.8.28
Component: adm Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description


Attachments

mc-4270-replace-obsolete-ac_prog_cc_stdc.patch (859 bytes) - added by and 5 months ago.
mc-4270-remove-unused-macros.patch (3.3 KB) - added by and 5 months ago.
mc-4270-filegui-fix-cid-331828-331850.patch (916 bytes) - added by and 3 months ago.
mc-4270-filegui-fix-cid-331837.patch (1.1 KB) - added by and 3 months ago.

Change History

comment:1 Changed 9 months ago by andrew_b

Last edited 7 months ago by andrew_b (previous) (diff)

comment:2 Changed 6 months ago by andrew_b

  • Branch state changed from no branch to merged

Merged to master: [eff779b246e667d3bdccb3a0ac2c6dca470ac624].

git lof ---pretty=oneline b8262f22e..eff779b24

comment:3 Changed 5 months ago by andrew_b

Changed 5 months ago by and

Changed 5 months ago by and

comment:4 Changed 5 months ago by andrew_b

mc-4270-remove-unused-macros.patch​: applied.
mc-4270-replace-obsolete-ac_prog_cc_stdc.patch​: applied.
Thanks!

comment:5 Changed 4 months ago by andrew_b

  • Blocking 4330 added

comment:6 Changed 3 months ago by and

I bump 4270_cleanup at scan.coverity.com to see was new in Coverity 2021.12.1 release.
Looks like coverity view defects login is still broken.

Changed 3 months ago by and

comment:7 Changed 3 months ago by andrew_b

Thanks! Applied with some modifications.

Changed 3 months ago by and

comment:8 Changed 3 months ago by andrew_b

Thanks! Applied.

comment:9 Changed 2 months ago by andrew_b

Merged to master: [7fe3f4c898d029e87faa439ebd7297214059f710].

git --log --pretty=oneline cbcda8a28..7fe3f4c89

comment:10 Changed 2 months ago by andrew_b

  • Blocking 4330 removed

comment:11 Changed 2 months ago by zaytsev

Hi Andrew,

I get the following warning while building:

../../../src/viewer/coord_cache.c: In function ‘mcview_ccache_add_entry’:
../../../src/viewer/coord_cache.c:97:5: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
   97 |     cache->cache[pos] = g_memdup (entry, sizeof (*entry));
      |     ^~~~~
In file included from /usr/include/glib-2.0/glib.h:82,
                 from ../../../lib/global.h:66,
                 from ../../../src/viewer/coord_cache.c:57:
/usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
  257 | gpointer              g_memdup         (gconstpointer mem,
      |                       ^~~~~~~~

Yury

comment:12 Changed 2 months ago by andrew_b

g_memdup has been deprecated since version 2.68 and should not be used in newly-written code.
Use g_memdup2() instead, as it accepts a gsize argument for byte_size, avoiding the possibility of overflow in a gsize → guint conversion

It's not critical in this case, because sizeof (*entry) is significantly less than SIZE_MAX.
Let's fix that after release.

comment:13 Changed 2 months ago by zaytsev

Fine with me - another one from ossie:

> find.c: In function ‘find_cmd’:
> find.c:1837:28: warning: ‘start_dir_len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   1837 |                 p = name + (size_t) start_dir_len;
>        |                            ^~~~~~~~~~~~~~~~~~~~~~
> find.c:1897:13: note: ‘start_dir_len’ was declared here
>   1897 |     ssize_t start_dir_len;
>        |             ^~~~~~~~~~~~~

For the record.

comment:14 Changed 8 weeks ago by zaytsev

  • Owner set to zaytsev
  • Status changed from new to accepted

prepare repository for release
download PO-translations from Transifex.net
store translations in git repo
download the hint translations from Transifex.net
store translations in git repo
create new NEWS wiki page for next version with empty template

NEWS-4.8.29

add content of current NEWS wiki page to the doc/NEWS file in git repo
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files

done

upload source packages and checksums to the special upload area
developers should download tarballs, verify checksums, compile and install locally

skipped

upload source packages and checksums
run command
update Wiki start page with latest release number

done

comment:15 Changed 8 weeks ago by zaytsev

  • Status changed from accepted to testing
  • Resolution set to fixed

write an announcement: list user visible changes (bugs and features)

done

create new ticket (type=task, component=adm) for the next release

#4357

close ticket for release
close current milestone

done

comment:16 Changed 8 weeks ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.