Prepare for release mc-4.8.28

[andrew_b]

Branch: 4270_cleanup
Initial changeset:662684d6b0d49a59f785c5a41bdc1f298a8c9370

[andrew_b]

Merged to master: [eff779b246e667d3bdccb3a0ac2c6dca470ac624].

git lof ---pretty=oneline b8262f22e..eff779b24

[andrew_b]

Branch: 4270_cleanup
Initial changeset:1a093a8125e109807c87280a4ef9ef458020a6a4

[andrew_b]

mc-4270-remove-unused-macros.patch​: applied.
mc-4270-replace-obsolete-ac_prog_cc_stdc.patch​: applied.
Thanks!

[and]

I bump 4270_cleanup at scan.coverity.com to see was new in Coverity 2021.12.1 release.
Looks like coverity view defects login is still broken.

[andrew_b]

Thanks! Applied with some modifications.

[andrew_b]

Thanks! Applied.

[andrew_b]

Merged to master: [7fe3f4c898d029e87faa439ebd7297214059f710].

git --log --pretty=oneline cbcda8a28..7fe3f4c89

[andrew_b]

(In #4330) Fixed as [185c80ffb79ca3506c6a38a341cb724642b4120c].

[zaytsev]

Hi Andrew,

I get the following warning while building:

../../../src/viewer/coord_cache.c: In function ‘mcview_ccache_add_entry’:
../../../src/viewer/coord_cache.c:97:5: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
   97 |     cache->cache[pos] = g_memdup (entry, sizeof (*entry));
      |     ^~~~~
In file included from /usr/include/glib-2.0/glib.h:82,
                 from ../../../lib/global.h:66,
                 from ../../../src/viewer/coord_cache.c:57:
/usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
  257 | gpointer              g_memdup         (gconstpointer mem,
      |                       ^~~~~~~~

Yury

[andrew_b]

g_memdup has been deprecated since version 2.68 and should not be used in newly-written code.
Use g_memdup2() instead, as it accepts a gsize argument for byte_size, avoiding the possibility of overflow in a gsize → guint conversion

It's not critical in this case, because sizeof (*entry) is significantly less than SIZE_MAX.
Let's fix that after release.

[zaytsev]

Fine with me - another one from ossie:

> find.c: In function ‘find_cmd’:
> find.c:1837:28: warning: ‘start_dir_len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   1837 |                 p = name + (size_t) start_dir_len;
>        |                            ^~~~~~~~~~~~~~~~~~~~~~
> find.c:1897:13: note: ‘start_dir_len’ was declared here
>   1897 |     ssize_t start_dir_len;
>        |             ^~~~~~~~~~~~~

For the record.

[zaytsev]

prepare repository for release
download PO-translations from Transifex.net
store translations in git repo
download the hint translations from Transifex.net
store translations in git repo
create new NEWS wiki page for next version with empty template

NEWS-4.8.29

add content of current NEWS wiki page to the doc/NEWS file in git repo
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files

done

upload source packages and checksums to the special upload area
developers should download tarballs, verify checksums, compile and install locally

skipped

upload source packages and checksums
run command
update Wiki start page with latest release number

done

[zaytsev]

write an announcement: list user visible changes (bugs and features)

done

create new ticket (type=task, component=adm) for the next release

#4357

close ticket for release
close current milestone

done