Ticket #4152 (closed defect: fixed)

Opened 6 weeks ago

Last modified 3 weeks ago

opening history dropdown marks line edits as modified

Reported by: ossi Owned by: andrew_b
Priority: minor Milestone: 4.8.26
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

a minor issue that has bugged me forever:
in the file search dialog, i often open the dropdown on the "content" line edit to see whether what i want to search for is already there (*). when it isn't, i'll just close it again. however, that is sufficient to mark the previous content as modified, so i have to manually delete it first instead of just typing ahead.

(*) that's more of a lottery than i'd like it to be due to the history not being synced between concurrent instances, but that's another issue.

Attachments

mc-4152-preserve-state-after-dropdown-break.patch (968 bytes) - added by and 6 weeks ago.

Change History

comment:1 follow-up: ↓ 2 Changed 6 weeks ago by zaytsev

  • Milestone changed from Future Releases to 4.8.26

Andrew, what do you think? I am also sometimes bugged by this behaviour.

comment:2 in reply to: ↑ 1 Changed 6 weeks ago by andrew_b

Replying to zaytsev:

Andrew, what do you think?

I think it should be fixed.

and's patch is not correct. If you open history using mouse, you get the same behavior. Patch doesn't fix that. In the current implementation, any key reset the initial state of input ("initial" means state before any key press) . For example, open copy dialog (press F5). You're in the "to" input line, and this input is in the initial state (has alter color). If you press the "left" key, initial state will reset, you can edit the text. With and's patch, left/right key movements keep the initial state, and if you try insert any letter, you clear the text.

The behavior of input completion is the same as described in the ticket description: press F5, press esc+tab to open completion window, close it. The initial state of input is reset. This should be fixed too.

So, there are two commands of input line that should be handled as special cases: CK_History and CK_Complete. If input line is in initial state and history or complete window was cancelled, initial state must be kept.

comment:3 Changed 6 weeks ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review

comment:4 Changed 6 weeks ago by ossi

thanks, works as expected. no opinion on code quality.

comment:5 Changed 3 weeks ago by andrew_b

  • Votes for changeset set to ossi andrew_b
  • Branch state changed from on review to approved

comment:6 Changed 3 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from ossi andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:7 Changed 3 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.