| 1 | | > Why this is a bug? |
| 2 | | |
| 3 | | Huh? |
| 4 | | |
| 5 | | You just suggested "What about get rid of $DISPLAY usage here at all", so how the application will be able to detect if it should use the data returned by clipboard_paste or not, in this case? |
| 6 | | |
| 7 | | In the current implementation, the application rewrites the clipboard data in clipboard_file_from_ext_clip() without checking the exit status of clipboard_paste, and I consider this behaviour as a bug. For example, if a user has not xclip installed or xclip invocation failed for any reason, any paste operation is effectively noop in mcedit, instead of falling back to the internal clipboard implementation. |
| 8 | | |
| 9 | | If you throw away the DISPLAY check, such a rather rare condition will turn into a common case. So clipboard_file_from_ext_clip() should be fixed for checking the non-zero exit status of clipboard_paste before deleting the DISPLAY check. |
| 10 | | |
| 11 | | Please point out why using any data returned by a failed shell command is NOT a bug in your opinion. |
| | 1 | (Deleted. Looks like My tests were incorrect. Sorry.) |
