Ticket #4132 (closed enhancement: fixed)
mcedit's 'command/Find declaration' dialogbox width is hardcoded to 64chars
| Reported by: | dextarr | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.27 |
| Component: | mcedit | Version: | master |
| Keywords: | ctag dialog width autoscale | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
The current CTAGS implementation has a fixed width dialog box:
src/editor/etags.h line 9
#define MAX_WIDTH_DEF_DIALOG 60
Nowadays probably many of us use mc in a bigger terminal than 80x25 so it would be awesome if the dialogbox in question would scale. i have to work with some long variable/function names and ugly nested path components which get really badly truncated in that tiny space.
e.g. the actual dialogbox width could be calculated using the longest 'label_def' (src/editor/editcmd_dialogs.c:456) the listbox get filled with. In case that turns out too wide then the COL of the terminal - some chars. This would/could still also be backward compatible for the 80x25 folks).
thanks for considering!
dextarr
Change History
comment:1 Changed 4 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.27
comment:2 Changed 4 years ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:3 Changed 4 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [32c28026f82436fd217472462b5e218feb7c0fc6].
git log --pretty=oneline 26e568cd7..32c28026f
Branch: 4132_tags_dialog_width
Initial changeset:46c37bf675590adbc8aeffaf0aec9c0207145460