C-w does not delete whole command line

[iNode]

C-w does not delete whole command line.

How to repeat. Enter in command line:

ls ls1<M-backspace><M-y><M-y><C-w>

As result we has "ls" in command line, but it also must be deleted!

[ossi]

see my comment in #357.
though i admittedly have no idea why the location of the mark is changed. maybe somebody feels like running the thing through valgrind?

[iNode]

Replying to ossi:

see my comment in #357.

In that case it not delete whole line or just one word. It's fully inconsistent.

The same thing happens in any input line, so it's widget problem, not command line
specific. So it's seems like kill_region->delete_region change in->mark in widget.c.

static void
delete_region (WInput *in, int x_first, int x_last)
{
   int first = min (x_first, x_last);
   int last  = max (x_first, x_last);
    size_t len;

   in->point = first;
   in->mark  = first; /* why? */

Why? I don't know.

So who see full picture and sure that not break anything can patch by delete that line.

[iNode]

I review some code near delete_region and I think that delete_region should not change the mark.

Also set_mark function seems to be forgotten:

    /* Region manipulation */
    { 0,              	  set_mark },
    { XCTRL('w'),     	  kill_region },

[iNode]

Oh, I find that use case. But we need set_mark work for it.

In that case mark can be in the end of line.

some input<cursor> some more input<mark>

And on C-w mark should be moved to cursor position, only in this case.

See patch. It also fix indent of some code block.

[iNode]

fix set mark on delete_region

[iNode]

fix set mark on delete_region, patch formated by git instead of diff

[slavazanko]

This bug raised with more simplest test case:

1) run mc
2) type 'word1 word2'
3) press Meta-backspace (after typing 'word2')
4) press Ctrl-w

[slavazanko]

Created branch 407_ctrl_w_not_delete_line

Initial changeset:068ef6f34529a3f0622393585291791410f49669

review, please.

[slavazanko]

merge changeset:92247810e5315a82c306605d33faf77efef96e80