Ticket #4057 (closed defect: fixed)

Opened 9 months ago

Last modified 6 months ago

'mcedit .' render blank screen with invisible error.

Reported by: slyfox Owned by: andrew_b
Priority: major Milestone: 4.8.25
Component: mc-core Version: 4.8.24
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

The simplest reproducer is to run mcedit . from an empty shell. mc used to show an error banner. Now it shows black-on-black error message. Somethomes I can see it for a short while when i'm resizing terminal window.

It's a regression in 4.8.24 (and current master) compared to 4.8.23.

Bisected down to the:

41abcbf706b97cebd8e127465469c69639da9f09 is the first bad commit
commit 41abcbf706b97cebd8e127465469c69639da9f09
Author: Andrew Borodin <aborodin@vmail.ru>
Date:   Mon Sep 2 15:00:58 2019 +0300

    Ticket #3380: enable subshell in standalone mceditor, mcviewer, and mcdiffviewer.

    Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

 src/execute.c            | 19 ++++++++++++-------
 src/main.c               |  4 ----
 src/subshell/common.c    | 16 +++++++---------
 src/subshell/internal.h  |  2 +-
 src/subshell/proxyfunc.c |  9 +++++++--
 5 files changed, 27 insertions(+), 23 deletions(-)

Change History

comment:1 Changed 6 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.25

Branch: 4057_invisible_error_dialog
changeset:b9cf2898c4ff660e4025264671faaa088c36b3ff

comment:2 Changed 6 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 6 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:4 Changed 6 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.