Ticket #3960 (closed defect: fixed)

Opened 11 days ago

Last modified 2 days ago

MC 4.8.22 doesn't compile on AIX 7.2

Reported by: dp Owned by: andrew_b
Priority: major Milestone: 4.8.23
Component: mc-core Version: 4.8.22
Keywords: Cc: jax, IBMJesseG
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Hi there,

The compilation fails on AIX 7.2 (7200-03-01-1838) with the following error messages:

make[3]: Entering directory '/home/dp/rpmbuild/BUILD/mc-4.8.22/src/filemanager'
  CC       achown.lo
achown.c: In function 'chl_callback':
achown.c:491:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
         switch (parm)
         ^~~~~~
achown.c:505:5: note: here
     default:
     ^~~~~~~
  CC       boxes.lo
  CC       chmod.lo
  CC       chown.lo
  CC       cmd.lo
  CC       command.lo
In function 'examine_cd',
    inlined from 'do_cd_command' at command.c:440:16:
command.c:172:25: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
                         strncpy (r, t, tlen + 1);
                         ^~~~~~~~~~~~~~~~~~~~~~~~
command.c: In function 'do_cd_command':
command.c:168:28: note: length computed here
                     tlen = strlen (t);
                            ^~~~~~~~~~
  CC       dir.lo
  CC       ext.lo
  CC       file.lo
file.c: In function 'get_times':
file.c:899:17: error: incompatible types when assigning to type 'struct timespec' from type 'st_timespec_t' {aka 'const struct st_timespec'}
     (*times)[0] = sb->st_atim;
                 ^
file.c:900:17: error: incompatible types when assigning to type 'struct timespec' from type 'st_timespec_t' {aka 'const struct st_timespec'}
     (*times)[1] = sb->st_mtim;
                 ^
make[3]: *** [Makefile:604: file.lo] Error 1
make[3]: Leaving directory '/home/dp/rpmbuild/BUILD/mc-4.8.22/src/filemanager'
make[2]: *** [Makefile:738: all-recursive] Error 1
make[2]: Leaving directory '/home/dp/rpmbuild/BUILD/mc-4.8.22/src'
make[1]: *** [Makefile:625: all-recursive] Error 1
make[1]: Leaving directory '/home/dp/rpmbuild/BUILD/mc-4.8.22'
make: *** [Makefile:553: all] Error 2

The full listing is attached.

Attachments

compilation.log (31.7 KB) - added by dp 11 days ago.
aix_fix.patch (458 bytes) - added by andrew_b 10 days ago.
compilation2.log (31.7 KB) - added by dp 7 days ago.

Change History

Changed 11 days ago by dp

comment:1 follow-up: ↓ 4 Changed 10 days ago by zaytsev

  • Cc jax, IBMJesseG added

Sounds like compilation on AIX got busted by PASE changes :( Does any of you have access to AIX / can help with that?

comment:2 Changed 10 days ago by andrew_b

Warning are fixed in the 3955_cleanup branch.

I guess the fix of compilation error for AIX should be the same as fix for IBM i: [a45337672be6f32df2a598f3fdc03e3c0b8f53ac].

Changed 10 days ago by andrew_b

comment:3 follow-up: ↓ 5 Changed 10 days ago by zaytsev

dp, could you please try the attached patch out? thanks!

comment:4 in reply to: ↑ 1 Changed 7 days ago by dp

Replying to zaytsev:

Sounds like compilation on AIX got busted by PASE changes :( Does any of you have access to AIX / can help with that?

Yes, of course. I can help you. I have an unlimited access to AIX.

comment:5 in reply to: ↑ 3 ; follow-up: ↓ 6 Changed 7 days ago by dp

Replying to zaytsev:

dp, could you please try the attached patch out? thanks!

I have done it, but the compilation failed again.((
Please find the new attached file compilation2.log.

Last edited 7 days ago by dp (previous) (diff)

Changed 7 days ago by dp

comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 7 days ago by andrew_b

Replying to dp:

I have done it, but the compilation failed again.((
Please find the new attached file compilation2.log.

There is no difference between logs.
Did you run autoreconf after apply patch to configure.ac?

comment:7 in reply to: ↑ 6 Changed 7 days ago by dp

Replying to andrew_b:

Replying to dp:

I have done it, but the compilation failed again.((
Please find the new attached file compilation2.log.

There is no difference between logs.
Did you run autoreconf after apply patch to configure.ac?

Sorry, no. I didn't know it. This time mc has been successfully compiled.

comment:8 Changed 2 days ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.23

comment:9 Changed 2 days ago by andrew_b

  • Votes for changeset set to dp andrew_b
  • Branch state changed from on review to approved

comment:10 Changed 2 days ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from dp andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:11 Changed 2 days ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.