Ticket #3955 (new task)

Opened 7 weeks ago

Last modified 8 days ago

Prepare for release mc-4.8.23

Reported by: zaytsev Owned by:
Priority: major Milestone: 4.8.23
Component: adm Version: master
Keywords: Cc: egmont
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description


Attachments

mc-3955-achown-cleanup-implicit-fallthrough-warning.patch (933 bytes) - added by and 6 weeks ago.
mc-3955-edit.c-cleanup-cast-align-warning.patch (1.3 KB) - added by and 6 weeks ago.
mc-3955-panel.c-cleanup-potential-conditional-uninitialized-warning.patch (1.2 KB) - added by and 6 weeks ago.
mc-3955-tar-cleanup-implicit-fallthrough-warning.patch (969 bytes) - added by and 6 weeks ago.
mc-3955-viewer-cleanup-string-conversion-warning.patch (2.2 KB) - added by and 6 weeks ago.
mc-3955-autoconf-cleanup-ac_error-obsolete-warning.patch (2.6 KB) - added by and 5 weeks ago.
mc-3955-autoconf-cleanup-ac_prog_libtool-obsolete-warning.patch (679 bytes) - added by and 5 weeks ago.
mc-3955-autoconf-cleanup-ac_try_link-obsolete-warning.patch (3.0 KB) - added by and 5 weeks ago.
mc-3955-autoconf-remove-obsolete-ac_onceonly_m4-file.patch (3.7 KB) - added by and 5 weeks ago.
mc-3955-editcmd_dialogs.c-cleanup-cast-align-warning.patch (1.7 KB) - added by and 5 weeks ago.
mc-3955-man2hlp-support-re-macro.patch (971 bytes) - added by and 5 weeks ago.
mc-3955-utilunix.c-cleanup-Wdangling_else-warning.patch (1008 bytes) - added by and 5 weeks ago.
mc-3955-dialog.c-cleanup-null-dereference-warning.patch (1.6 KB) - added by and 4 weeks ago.
mc-3955-dir.c-cleanup-null-dereference-warning.patch (1.2 KB) - added by and 4 weeks ago.
mc-3955-direntry.c-cleanup-null-dereference-warning.patch (3.7 KB) - added by and 4 weeks ago.
mc-3955-interface.c-cleanup-null-dereference-warning.patch (1.1 KB) - added by and 4 weeks ago.
mc-3955-file.c-cleanup-cppcheck-warning.patch (1.6 KB) - added by and 2 weeks ago.
mc-3955-hex.c-cleanup-cppcheck-warning.patch (1.1 KB) - added by and 2 weeks ago.
mc-3955-panel.c-cleanup-cppcheck-warning.patch (908 bytes) - added by and 2 weeks ago.
mc-3955-setup.c-cleanup-cppcheck-warning.patch (970 bytes) - added by and 2 weeks ago.
mc-3955-autoconf-fix-gcc-function-check-detection.patch (1.1 KB) - added by and 2 weeks ago.

Change History

comment:1 Changed 7 weeks ago by andrew_b

comment:2 Changed 7 weeks ago by egmont

  • Cc egmont added

Changed 6 weeks ago by and

comment:3 Changed 5 weeks ago by andrew_b

Thanks!

mc-3955-achown-cleanup-implicit-fallthrough-warning.patch​ and
mc-3955-tar-cleanup-implicit-fallthrough-warning.patch​: squashed and applied.
mc-3955-panel.c-cleanup-potential-conditional-uninitialized-warning.patch​: will be squashed with the original commit.
mc-3955-edit.c-cleanup-cast-align-warning.patch​: no need NULLization of WEdit members before purge.
mc-3955-viewer-cleanup-string-conversion-warning.patch​: these assertion are removed.

comment:4 Changed 5 weeks ago by and

Great, next chunks will come

comment:5 Changed 5 weeks ago by andrew_b

Thanks!
mc-3955-autoconf-cleanup-ac_error-obsolete-warning.patch​: applied.
mc-3955-autoconf-cleanup-ac_prog_libtool-obsolete-warning.patch​: applied.
mc-3955-autoconf-cleanup-ac_try_link-obsolete-warning.patch​: applied.
mc-3955-autoconf-remove-obsolete-ac_onceonly_m4-file.patch​: applied.

Changed 5 weeks ago by and

comment:6 Changed 4 weeks ago by andrew_b

Thanks!

mc-3955-editcmd_dialogs.c-cleanup-cast-align-warning.patch​: applied.
mc-3955-man2hlp-support-re-macro.patch​: applied.
mc-3955-utilunix.c-cleanup-Wdangling_else-warning.patch​: another fix is applied.

comment:7 Changed 3 weeks ago by andrew_b

I thinks GCC is paranoid in those cases.

mc-3955-dialog.c-cleanup-null-dereference-warning.patch​
Widget list in the dialog cannot contain empty elements. Dialog list cannot contain empty elements too. I simplified some checks.

mc-3955-dir.c-cleanup-null-dereference-warning.patch​
vpath_str is NULL only if vpath is NULL. vpath is argument of dir_list_load() and should never be NULL.
I think, this is a common case when a function cannot accept NULL (e.g. strlen).

mc-3955-direntry.c-cleanup-null-dereference-warning.patch
The same about accepting of NULL.

mc-3955-interface.c-cleanup-null-dereference-warning.patch​
Can't say when vfs_path_get_last_path_vfs() can return NULL. If it occurs, this is abnormal case and should be fixed.

Changed 2 weeks ago by and

Changed 2 weeks ago by and

Changed 2 weeks ago by and

Changed 2 weeks ago by and

comment:8 Changed 2 weeks ago by andrew_b

mc-3955-file.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-hex.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-panel.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-setup.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-autoconf-fix-gcc-function-check-detection.patch​: applied.

Thanks!

comment:9 Changed 2 weeks ago by andrew_b

Branch 3955_cleanup rebased on top of recent master.
Initial changeset:1dd8a47987ebd3d02f333163e2221a591856fe6f

At this moment, 3955_cleanup has about 50 commits. I'm planing to test this branch next week and then merge it into master if there are no regressions. Then we will continue to clean up.

comment:10 Changed 10 days ago by andrew_b

Merged to master: [e806c2bac667cf59d38980b3c6806394a8c9c7c7].

git log --pretty=oneline 76d6430..e806c2b

New branch HEAD: [e806c2bac667cf59d38980b3c6806394a8c9c7c7]

comment:11 Changed 8 days ago by andrew_b

Note: See TracTickets for help on using tickets.