Ticket #3955 (closed task: fixed)

Opened 12 months ago

Last modified 6 months ago

Prepare for release mc-4.8.23

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.8.23
Component: adm Version: master
Keywords: Cc: egmont
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description


Attachments

mc-3955-achown-cleanup-implicit-fallthrough-warning.patch (933 bytes) - added by and 11 months ago.
mc-3955-edit.c-cleanup-cast-align-warning.patch (1.3 KB) - added by and 11 months ago.
mc-3955-panel.c-cleanup-potential-conditional-uninitialized-warning.patch (1.2 KB) - added by and 11 months ago.
mc-3955-tar-cleanup-implicit-fallthrough-warning.patch (969 bytes) - added by and 11 months ago.
mc-3955-viewer-cleanup-string-conversion-warning.patch (2.2 KB) - added by and 11 months ago.
mc-3955-autoconf-cleanup-ac_error-obsolete-warning.patch (2.6 KB) - added by and 11 months ago.
mc-3955-autoconf-cleanup-ac_prog_libtool-obsolete-warning.patch (679 bytes) - added by and 11 months ago.
mc-3955-autoconf-cleanup-ac_try_link-obsolete-warning.patch (3.0 KB) - added by and 11 months ago.
mc-3955-autoconf-remove-obsolete-ac_onceonly_m4-file.patch (3.7 KB) - added by and 11 months ago.
mc-3955-editcmd_dialogs.c-cleanup-cast-align-warning.patch (1.7 KB) - added by and 11 months ago.
mc-3955-man2hlp-support-re-macro.patch (971 bytes) - added by and 11 months ago.
mc-3955-utilunix.c-cleanup-Wdangling_else-warning.patch (1008 bytes) - added by and 11 months ago.
mc-3955-dialog.c-cleanup-null-dereference-warning.patch (1.6 KB) - added by and 11 months ago.
mc-3955-dir.c-cleanup-null-dereference-warning.patch (1.2 KB) - added by and 11 months ago.
mc-3955-direntry.c-cleanup-null-dereference-warning.patch (3.7 KB) - added by and 11 months ago.
mc-3955-interface.c-cleanup-null-dereference-warning.patch (1.1 KB) - added by and 11 months ago.
mc-3955-file.c-cleanup-cppcheck-warning.patch (1.6 KB) - added by and 10 months ago.
mc-3955-hex.c-cleanup-cppcheck-warning.patch (1.1 KB) - added by and 10 months ago.
mc-3955-panel.c-cleanup-cppcheck-warning.patch (908 bytes) - added by and 10 months ago.
mc-3955-setup.c-cleanup-cppcheck-warning.patch (970 bytes) - added by and 10 months ago.
mc-3955-autoconf-fix-gcc-function-check-detection.patch (1.1 KB) - added by and 10 months ago.

Change History

comment:1 Changed 11 months ago by andrew_b

comment:2 Changed 11 months ago by egmont

  • Cc egmont added

comment:3 Changed 11 months ago by andrew_b

Thanks!

mc-3955-achown-cleanup-implicit-fallthrough-warning.patch​ and
mc-3955-tar-cleanup-implicit-fallthrough-warning.patch​: squashed and applied.
mc-3955-panel.c-cleanup-potential-conditional-uninitialized-warning.patch​: will be squashed with the original commit.
mc-3955-edit.c-cleanup-cast-align-warning.patch​: no need NULLization of WEdit members before purge.
mc-3955-viewer-cleanup-string-conversion-warning.patch​: these assertion are removed.

comment:4 Changed 11 months ago by and

Great, next chunks will come

comment:5 Changed 11 months ago by andrew_b

Thanks!
mc-3955-autoconf-cleanup-ac_error-obsolete-warning.patch​: applied.
mc-3955-autoconf-cleanup-ac_prog_libtool-obsolete-warning.patch​: applied.
mc-3955-autoconf-cleanup-ac_try_link-obsolete-warning.patch​: applied.
mc-3955-autoconf-remove-obsolete-ac_onceonly_m4-file.patch​: applied.

Changed 11 months ago by and

comment:6 Changed 11 months ago by andrew_b

Thanks!

mc-3955-editcmd_dialogs.c-cleanup-cast-align-warning.patch​: applied.
mc-3955-man2hlp-support-re-macro.patch​: applied.
mc-3955-utilunix.c-cleanup-Wdangling_else-warning.patch​: another fix is applied.

comment:7 Changed 11 months ago by andrew_b

I thinks GCC is paranoid in those cases.

mc-3955-dialog.c-cleanup-null-dereference-warning.patch​
Widget list in the dialog cannot contain empty elements. Dialog list cannot contain empty elements too. I simplified some checks.

mc-3955-dir.c-cleanup-null-dereference-warning.patch​
vpath_str is NULL only if vpath is NULL. vpath is argument of dir_list_load() and should never be NULL.
I think, this is a common case when a function cannot accept NULL (e.g. strlen).

mc-3955-direntry.c-cleanup-null-dereference-warning.patch
The same about accepting of NULL.

mc-3955-interface.c-cleanup-null-dereference-warning.patch​
Can't say when vfs_path_get_last_path_vfs() can return NULL. If it occurs, this is abnormal case and should be fixed.

Changed 10 months ago by and

Changed 10 months ago by and

Changed 10 months ago by and

Changed 10 months ago by and

comment:8 Changed 10 months ago by andrew_b

mc-3955-file.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-hex.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-panel.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-setup.c-cleanup-cppcheck-warning.patch​: applied.
mc-3955-autoconf-fix-gcc-function-check-detection.patch​: applied.

Thanks!

comment:9 Changed 10 months ago by andrew_b

Branch 3955_cleanup rebased on top of recent master.
Initial changeset:1dd8a47987ebd3d02f333163e2221a591856fe6f

At this moment, 3955_cleanup has about 50 commits. I'm planing to test this branch next week and then merge it into master if there are no regressions. Then we will continue to clean up.

comment:10 Changed 10 months ago by andrew_b

Merged to master: [e806c2bac667cf59d38980b3c6806394a8c9c7c7].

git log --pretty=oneline 76d6430..e806c2b

New branch HEAD: [e806c2bac667cf59d38980b3c6806394a8c9c7c7]

comment:11 Changed 10 months ago by andrew_b

Last edited 9 months ago by andrew_b (previous) (diff)

comment:12 Changed 8 months ago by andrew_b

Merged to master: [e1d11906b37b65756857786a4caf4f8f2b4f29b4].

git log --pretty=oneline 91d6d55..e1d1190

comment:13 Changed 7 months ago by andrew_b

Last edited 7 months ago by andrew_b (previous) (diff)

comment:14 Changed 6 months ago by andrew_b

Merged to master: [846d92b9b7f2ccf2e8edc370aa37379784409244].

git log --pretty=oneline 0cf2ded64..846d92b9b

comment:15 Changed 6 months ago by zaytsev

prepare repository for release

done

download PO-translations from Transifex.net

done

store translations in git repo

done

download the hint translations from Transifex.net

done

store translations in git repo

done

create new NEWS wiki page for next version

done

add content of current NEWS wiki page to the doc/NEWS file in git repo

done

new version in Trac

done

new milestone in Trac

done

comment:16 Changed 6 months ago by zaytsev

  • Owner set to zaytsev
  • Status changed from new to accepted

comment:17 Changed 6 months ago by zaytsev

  • Branch state changed from no branch to on review

create new tag in git by command

done (not pushed yet)

create tar.(bz2|xz) package files

done

make checksums for archives

done

upload source packages and checksums to the special upload area

done - https://www.midnight-commander.org/nopaste/tarball/

comment:18 Changed 6 months ago by andrew_b

  • Votes for changeset set to andrew_b

comment:19 Changed 6 months ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from on review to approved

developers should download tarballs

done

upload source packages and checksums

done

update Wiki start page with latest release number

done

write an announcement

done

create new ticket

#3997

close ticket for release

done

close current milestone

done

comment:20 Changed 6 months ago by zaytsev

  • Status changed from testing to closed
  • Branch state changed from approved to merged
Note: See TracTickets for help on using tickets.