Ticket #3929 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Files .docx/.xlsx/.pptx created/edited in LibreOffice are not detected as MS Office files

Reported by: anatoly.borodin Owned by: andrew_b
Priority: minor Milestone: 4.8.22
Component: mc-core Version: 4.8.19
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Files saved in the "2007-2013 XML" format by LibreOffice? have different file type reported by file (file 1:5.32-2ubuntu0.1, Ubuntu 18.04 Bionic Beaver) and are therefore not detected as MS Office documents by mc.ext:

test.docx: Microsoft OOXML
test.pptx: Microsoft OOXML
test.xlsx: Zip archive data, at least v2.0 to extract

(I will file a separate bug at Launchpad or Debian regarding the xlsx file)

For a file created by the real MS Office I get

ms-office.docx: Microsoft Word 2007+

There are two possibilities to fix it:

  1. Add something like this to mc.ext.in
type/^Microsoft\ OOXML
        Open=@EXTHELPERSDIR@/doc.sh open ooffice
  1. Detect the files by regex/i.

Which fix is better?

Attachments

test.docx (4.0 KB) - added by anatoly.borodin 3 months ago.
test.pptx (20.3 KB) - added by anatoly.borodin 3 months ago.
test.xlsx (4.6 KB) - added by anatoly.borodin 3 months ago.

Change History

Changed 3 months ago by anatoly.borodin

Changed 3 months ago by anatoly.borodin

Changed 3 months ago by anatoly.borodin

comment:1 Changed 3 months ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.22

Branch: 3929_office_formats_ext
Initial changeset:feab399109becde9bb3b00114caf34fdbf128271

comment:2 Changed 3 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 3 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [5f80acde8753f95f2dfd9be40d038ca223fe5433].

git log ==pretty=oneline 4059d3a..5f80acd

comment:4 Changed 3 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.