Ticket #3912 (new defect)

Opened 10 months ago

Last modified 7 weeks ago

Update xls2csv usage since it's called with invalid parameters

Reported by: adamm Owned by:
Priority: minor Milestone: 4.8.23
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

xls2csv only prints error page and returns EXIT CODE 0
when only supplied a spreadsheet without -x parameter.
-c parameter also mandatory.


Currently permitted parameters are:


usage: xls2csv -x spreadsheet.xls [-w worksheet]

[-n worksheet number] [-b charset] [-c csvfile.csv]
[-a charset] [-qshvWf]


This is xls2csv version 1.07


Which is latest version in openSUSE:Factory

Attaching git patch

Attachments

0001-Update-xls2csv-usage.patch (1.1 KB) - added by adamm 10 months ago.

Change History

Changed 10 months ago by adamm

comment:1 Changed 10 months ago by zaytsev

  • Milestone changed from Future Releases to 4.8.21

Hi Andrew, looks good to me!

comment:2 Changed 10 months ago by andrew_b

Are we going to drop an old version of xls2csv?
As I can see in man page there is incompatibility in -c option:
old: -cchar cell separator char. By default - comma.
new: -c csvfile.csv

Last edited 10 months ago by andrew_b (previous) (diff)

comment:3 Changed 9 months ago by zaytsev

  • Milestone changed from 4.8.21 to 4.8.22

comment:4 Changed 7 weeks ago by zaytsev

  • Milestone changed from 4.8.22 to 4.8.23
Note: See TracTickets for help on using tickets.