Ticket #3869 (new defect) — at Initial Version

Opened 7 years ago

Last modified 5 years ago

ftp: fail to retrieve password from .netrc when user is in URL

Reported by: cri Owned by:
Priority: major Milestone: 4.8.20
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

I have a proper entry in ~/.netrc for USERNAME, PASSWORD and HOST.

If I try to access the URL ftp://HOST/PATH, mc correctly retrieves USERNAME and PASSWORD from .netrc and I can log into the FTP host.

If I try to access the URL ftp://USERNAME@HOST/PATH, mc displays a popup window, asking for the password. Shouldn't it retrieve the password from .netrc?

I had a look at https://midnight-commander.org/browser/src/vfs/ftpfs/ftpfs.c#L371

shouldn't it be

...&& path_element->password == NULL

instead of

...&& path_element->password != NULL

?

Or am I missing something?

Note: See TracTickets for help on using tickets.