Ticket #3855 (closed defect: fixed)

Opened 4 weeks ago

Last modified 2 weeks ago

[mcview] Search doesn't ask about starting over

Reported by: egmont Owned by: andrew_b
Priority: major Milestone: 4.8.20
Component: mcview Version: 4.8.19
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Regression since 4.8.19:

In mcview search for something that is found, then press 'n' or Shift+F7 repeatedly.

After the last match, it silently wraps around and searches again from the beginning. Previously it used to ask the user: "Search done – Continue from beginning?"

This is especially annoying when the searched string only appears once in the file. In this case absolutely no feedback is presented, apparently nothing happens on 'n' or Shift+F7.

Attachments

3855.patch (755 bytes) - added by andrew_b 4 weeks ago.

Change History

comment:1 Changed 4 weeks ago by egmont

Changed 4 weeks ago by andrew_b

comment:2 Changed 4 weeks ago by andrew_b

Please test the attached patch.

comment:3 Changed 4 weeks ago by egmont

  • Votes for changeset set to egmont

After some quick testing it looks good, thanks a lot! I'll keep using this version and report if anything comes up.

comment:4 Changed 4 weeks ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Version changed from master to 4.8.19
  • Branch state changed from no branch to on review

Branch: 3855_mcview_seach_ask_continue_from_begin
changeset:1221900262dd4a1fcd061b89cc25e7a96f978d5c

comment:5 Changed 2 weeks ago by andrew_b

  • Votes for changeset changed from egmont to egmont andrew_b
  • Branch state changed from on review to approved

comment:6 Changed 2 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from egmont andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:7 Changed 2 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.