Ticket #3850 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

Cannot cancel chmod for large group of files when chmod operation is not permitted

Reported by: victor-homyakov Owned by: andrew_b
Priority: minor Milestone: 4.8.21
Component: mc-core Version: master
Keywords: chmod Cc:
Blocked By: Blocking:
Branch state: approved Votes for changeset: committed-master


What version of Midnight Commander is used?
GNU Midnight Commander, версия 4.8.19
Скомпилирован с библиотекой GLib версии 2.50.3
С библиотекой S-Lang и с базой данных terminfo
Со встроенным редактором
C поддержкой внутренней командной оболочки
С поддержкой фоновых операций
С поддержкой мыши в xterm
С поддержкой интернационализации
С поддержкой многих кодировок
Виртуальная файловая система: cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish
Тип данных: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

What steps will reproduce the problem?

  1. I've selected about 12000 files
  2. Ctrl+x c (chmod) - changed mode to desired one
  3. MC started to change file modes but failed, it shows error popup "Невозможно изменить режим доступа к ... Operation not permitted (1)" for every file and waits for a keypress

Actual behavior:
MC shows error for every file in a list (12000 times), there is no chance to cancel the whole operation, only to press any key 12000 times or to kill MC

What is the expected behavior?
There should be buttons like "Ignore all errors", "Cancel operation"

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

Yes, this is really annoying behaviour. chown and advanced chown commands should be fixed too.

comment:2 Changed 7 years ago by andrew_b

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.20

Branch: 3850_chmod_chown_abort
Initial changeset:c8699d2d53b350721e0d1d86f18908727be96a6d

Last edited 7 years ago by andrew_b (previous) (diff)

comment:3 Changed 7 years ago by zaytsev

  • Milestone changed from 4.8.20 to 4.8.21

comment:4 Changed 7 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed

Merged to master: [434239f29a4b27369ebfb3e7e0d7e5bdb4c61e9d].

git log --pretty=oneline 3a5da75..434239f

comment:6 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.