Ticket #3846 (closed defect: fixed)

Opened 3 weeks ago

Last modified 2 weeks ago

crash on startup (SIGSEGV) with MALLOC env variables

Reported by: narcan Owned by: andrew_b
Priority: minor Milestone: 4.8.20
Component: mcview Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Step to reproduce:

$ MALLOC_PERTURB_=254 MALLOC_CHECK_=2 mc

then during the startup: hit "Ctrl+x g" keys combo

Important: you must hit "Ctrl+x g" keys before the panels are displayed.
To reproduce this long start, the user has got 370 sub-directories in the current directory.

see https://bugs.debian.org/870728 for more details

valgrind report attached

Thank you

Denis Briand

Attachments

valgrind.txt (341.2 KB) - added by zaytsev 3 weeks ago.
3846_mcview_hook.patch (511 bytes) - added by andrew_b 3 weeks ago.

Change History

comment:1 Changed 3 weeks ago by andrew_b

"Ctrl-x + g" is unbound by default. Do you mean "Ctrl-x + q"?

comment:2 Changed 3 weeks ago by zaytsev

  • Version changed from master to 4.8.18

From looking at the backtrace and valgrind report its sounds very much like #3700 to me (use after free in vfs_path_free), but with quick view panel involved now. Also, set field the version correctly.

Changed 3 weeks ago by zaytsev

comment:3 Changed 3 weeks ago by andrew_b

Perhaps, this is very much like #2657. The root of problem is action with dialog while it is being initialized. While dialog initialization is not finished, dialog should ignore or put key and/or mouse events off.

Last edited 3 weeks ago by andrew_b (previous) (diff)

comment:4 Changed 3 weeks ago by zaytsev

FYI, Denis has just confirmed

Oops its ctrl+x q of course :)

Changed 3 weeks ago by andrew_b

comment:5 Changed 3 weeks ago by andrew_b

Please test the attached 3846_mcview_hook.patch.

comment:6 Changed 2 weeks ago by zaytsev

Hi Andrew! Paul says that the patch has solved the problem for him. See the Debian ticket for the details. Many thanks!

comment:7 Changed 2 weeks ago by andrew_b

  • Status changed from new to accepted
  • Component changed from mc-core to mcview
  • Version changed from 4.8.18 to master
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.20
  • Owner set to andrew_b

comment:8 Changed 2 weeks ago by zaytsev

  • Votes for changeset set to zaytsev

Left a typo fix comment on github.

comment:9 Changed 2 weeks ago by andrew_b

  • Branch state changed from on review to approved

comment:10 Changed 2 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
Last edited 2 weeks ago by andrew_b (previous) (diff)

comment:11 Changed 2 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.