Ticket #3805 (closed defect: fixed)

Opened 4 weeks ago

Last modified 2 weeks ago

mcview and mcedit --help are wrong

Reported by: vda Owned by: andrew_b
Priority: major Milestone: 4.8.20
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Currently they show the same text as "mc --help"
(only the name of the command is shown based on executable name).

I checked manpages and I think something like this would be appropriate:

mcedit [-bcCdfhstVx?] [+lineno] [file1] [file2] ...
mcedit [-bcCdfhstVx?] file1:lineno[:] file2:lineno[:] ...

  +lineno	Go to this line number (first file only)
  -b		Black and white display
  -c		Use ANSI colors even if terminal don't seem to support it
  -C <keyword>=<fgcolor>,<bgcolor>,<attributes>:<keyword>=...
		Use different color set (see "man mc")
  -d		Disable mouse support
  -t		Use termcap database instead of terminfo
^^^^^^^^^^^^^^^^^^^^^^^^only applicable if compiled with terminfo support
  -x		Force xterm mode (two screen modes, mouse escape sequences)
  -f		Display compiled-in search path for data files
  -V,--version  Display version


mcview [-bcCdfhstVx?] file

  -b		Black and white display
  -c		Use ANSI colors even if terminal don't seem to support it
  -C <keyword>=<fgcolor>,<bgcolor>,<attributes>:<keyword>=...
		Use different color set (see "man mc")
  -d		Disable mouse support
  -t		Use termcap database instead of terminfo
^^^^^^^^^^^^^^^^^^^^^^^^only applicable if compiled with terminfo support
  -x		Force xterm mode (two screen modes, mouse escape sequences)
  -f		Display compiled-in search path for data files
  -V,--version  Display version

(I usually do not include --help option in help text, since user, evidently,
already knows this option (he just used it!), thus why waste screen space)

Attachments

0001-Fix-help-option-to-show-correct-syntax-for-editor-vi.patch (5.5 KB) - added by vda 2 weeks ago.
Patch is attached. Run-tested.

Change History

Changed 2 weeks ago by vda

Patch is attached. Run-tested.

comment:1 Changed 2 weeks ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.20

Thanks!

Branch: 3805_help_message
changeset:486f3d2f818c73f10b7d6af119eeccf00f51d44c

comment:2 Changed 2 weeks ago by zaytsev

  • Votes for changeset set to zaytsev
  • Branch state changed from on review to approved

comment:3 Changed 2 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [161e3a1719a42fd5cac0b927ca284f9ca4a85ae9].

git log --pretty=oneline f4eb2c4..161e3a1

comment:4 Changed 2 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.