Ticket #3794 (closed enhancement: fixed)

Opened 13 days ago

Last modified 11 days ago

TypeScript syntax support

Reported by: mortiy Owned by: zaytsev
Priority: minor Milestone: 4.8.20
Component: mcedit Version: master
Keywords: typescript Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Attachments

0001-TypeScript-syntax-support.patch (7.5 KB) - added by mortiy 13 days ago.
TypeScript? syntax patch

Change History

Changed 13 days ago by mortiy

TypeScript? syntax patch

comment:1 Changed 12 days ago by zaytsev

Hi!

I can merge this, but I'm not really sure it's worth making a separate syntax for TypeScript. It's basically ES6 with interfaces and typing right? One benefit of adding TS stuff to JS syntax that I can think of is that it will automatically highlight flow annotations as well.

How do you feel about that?

Thanks!

comment:2 Changed 12 days ago by mortiy

Hi,

Yes, you are right, but besides typing there are also enums, access modifiers (private, protected, public), @decorators and several more keywords.

The point is that TypeScript? may go further and I am not sure if it is correct to fill js.syntax (which is more or less stable) with all that stuff.

For the same reason I think flow.js is out of js.syntax scope.

Do you agree? :)

comment:3 Changed 11 days ago by zaytsev

  • Owner set to zaytsev
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.20

comment:4 Changed 11 days ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged

comment:5 Changed 11 days ago by zaytsev

  • Status changed from testing to closed

Ok, I agree about TypeScript?, but I still think that support for flow annotations should be added to js.syntax (if anyone will ever get to that). Thank you for the contribution!

Note: See TracTickets for help on using tickets.