mcedit: Weird coordinates for maximize/close mouse buttons

[egmont]

In the upper row of mcedit, there are two buttons (the actual symbols vary across skins):

[*][X]

Click with the mouse to observe the following:

• the leftmost [ invokes the pulldown menu (just as if you clicked anywhere to the left),

• the next three cells: *][ invoke the "(un)maximize" action,

• the last two cells: X] close the editor.

This looks like a simple off-by-one.

Also, once you unmaximize, the behavior changes there: It's only the exact * and X symbols that perform the given action, the surrounding brackets drag the frame for moving. It would be nice if the maximized and unmaximized cases were consistent. (I guess having all three adjacent cells perform the desired action results in better usability – what do you think?)

[egmont]

Fix

[zaytsev]

branch: 3774_editor_buttons
changeset: fa951f8c5d8786554abc8bb1a7e1a88f0f03e01a

[mooffie]

I tested/reviewed the patch and it's fine.

(It's a pity there's now more verbiage that repeats. Perhaps it can be fixed with macros (FUZZY_EQ(event->x, close_x, 1)) or variables (on_close_btn), but maybe we should just leave it as is.)

(And, only in case anybody gets to edit the code again: better fix "int dx"'s comment to read: "/* buttons' distance from right edge */".)

[egmont]

The problem with the FUZZY_EQ approach would be that it only works as long as the overall sensitive width is odd.

I was wondering for a second that maybe I should declare and initialize close_x_start, close_x_end and similarly for the other one, but it wouldn't have significantly simplified things (plus would have introduced the standard doubt: should the end be inclusive or exclusive?).

[zaytsev]

Merged to master: 1a3ba4edbdd461efba16dc8ee4c0d52da94fdacc

[zaytsev]

Thank you Egmont & Mooffie!