Ticket #3753 (closed task: fixed)

Opened 6 months ago

Last modified 6 months ago

extfs: tester: let test scripts easily access configure-time parameters.

Reported by: mooffie Owned by: mooffie
Priority: major Milestone: 4.8.19
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: #3752 Blocking: #3751
Branch state: merged Votes for changeset: committed-master

Description

This patch introduces a mechanism by which tests can easily access configure-time parameters, like @PERL@, @AWK@, etc.

(The traditional method, of *.in files, can still be used of course, but this mechanism is more comfortable.)

Rationale

As seen in #3751, tests should have access to configure-time parameters. After committing this patch, the file 'data/rpm.rewrite.sh' could be written as follows:

. "$MC_TEST_EXTFS_CONFIG_SH"

blah_blah_blah()
{
  $PERL -e 'whatever perl code'
}

Change History

comment:1 Changed 6 months ago by mooffie

  • Blocking 3751 added

comment:2 Changed 6 months ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.19

comment:3 follow-up: ↓ 4 Changed 6 months ago by zaytsev

I have convened with Andrew earlier this week, and we both agree that on the basis of your contributions you should be granted commit access to the source repository (a long time ago ;-) ). Today, I have cleaned up our GitHub organization settings and sent you an invitation to join the committers team. If anything, this will save us all a lot of time posting patches to Trac & creating branches from them. What do you think?

In terms of workflows, I believe that you might have followed our conversation with Egmont on the mailing list, and I hope that this also works for you... I'd be happy to discuss whatever you think is worth being discussed and help you if you need any help, but vacation time is over, and so I will be able to make as much time than I spent in the last couple of weeks :-/

comment:4 in reply to: ↑ 3 Changed 6 months ago by mooffie

Replying to zaytsev:

I have convened with Andrew earlier this week, and we both agree that [...] sent you an invitation to join the committers team


Andrew and Yury: thank you for your vote of confidence!

What do you think?


Superb.

In terms of workflows, I believe that you might have followed our conversation with Egmont on the mailing list,


Yes.

This post (and this one) contains everything.

I already started the workflow for #3752 (which blocks this ticket). Once I merge that one I'll handle this ticket.

(I won't be here till Sunday.)

comment:5 Changed 6 months ago by zaytsev

  • Owner changed from zaytsev to mooffie
  • Status changed from accepted to assigned

Awesome!

comment:6 Changed 6 months ago by mooffie

  • Branch state changed from no branch to on review

branch: 3753_extfs_tester_access_configure_parameters
changeset:69897e94fd996ff92ad3df09bb82dae18add0320

comment:7 Changed 6 months ago by zaytsev

  • Votes for changeset set to zaytsev
  • Branch state changed from on review to approved

comment:8 Changed 6 months ago by mooffie

  • Status changed from assigned to testing
  • Votes for changeset changed from zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:9 Changed 6 months ago by mooffie

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.