Ticket #3744 (closed task: fixed)

Opened 11 months ago

Last modified 11 months ago

Tests for extfs's u7z filesystem

Reported by: mooffie Owned by: zaytsev-work
Priority: major Milestone: 4.8.19
Component: tests Version: master
Keywords: Cc:
Blocked By: #2707, #3730 Blocking: #3729
Branch state: merged Votes for changeset: committed-master

Description

Here are tests for the u7z filesystem (for the "list" command).

They test the fixes in #2707, so you have to commit #2707 first (or the tests will fail).

Now, this is not the final patch because I'm waiting for @Andrew to tell me the name of the tester's folder. I'll re-roll the patch once I know it.

Attachments

3744-0001-extfs-u7z-make-it-testable.patch (1.3 KB) - added by mooffie 11 months ago.
3744-0002-extfs-u7z-add-tests.patch (21.5 KB) - added by mooffie 11 months ago.

Change History

comment:1 Changed 11 months ago by zaytsev

Ah, the MC_TEST_EXTFS_U7Z_STAT="echo ..." trick is genius, when I was saying it will be more annoying to test, I was referring to stat and subsequent ls call.

Changed 11 months ago by mooffie

Changed 11 months ago by mooffie

comment:2 Changed 11 months ago by mooffie

The patches were updated:

  • The paths are the final ones now.
  • There's a new test, u7z.missing-size-and-date.input, that tests the "both compressed and uncompressed sizes may be missing" issue reported by @birdie in ticket 2707. (This test will fail unless you commit the newest patches from #2707.)

comment:3 Changed 11 months ago by mooffie

  • Blocking 3729 added

(In #3729)
I'm marking this "blocked by #3744". The tickets are unrelated but both touch Makefile.am and will therefore result in merge conflict unless ordered.

comment:4 Changed 11 months ago by zaytsev-work

  • Status changed from new to accepted
  • Owner set to zaytsev-work

comment:5 Changed 11 months ago by zaytsev-work

  • Milestone changed from Future Releases to 4.8.19

comment:6 Changed 11 months ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 3744_u7z_tests
Initial changeset: [fad265c5bd29d989e7f474905ed219b1b8a9526c]

Last edited 11 months ago by andrew_b (previous) (diff)

comment:7 Changed 11 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:8 Changed 11 months ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:9 Changed 11 months ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.