Ticket #3710 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

window-state-char parsed as color

Reported by: egmont Owned by: andrew_b
Priority: trivial Milestone: 4.8.19
Component: mc-skin Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master


A very insignificant internal issue that probably will never lead to a user-visible bug:

In skin files, the "[editor]" section's "window-state-char" and "window-close-char" (whose values, as the name implies, are single characters) are parsed as color fg+bg+attr, and an ncurses/slang colorpair is allocated for each.

This is because lib/skin/colors.c mc_skin_color_parse_ini_file() iterates through all the sections (excluding a few according to mc_skin_color_check_inisection()) and then in these sections parses all the entries as colors.

Change History

comment:1 Changed 6 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:2 Changed 6 years ago by andrew_b

  • Type changed from enhancement to defect
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.19

Branch: 3710_parse_window_state_char

comment:3 Changed 6 years ago by egmont

Thanks Andrew!

Just for the record, this patch works because mc_skin_color_check_inisection() filters out sections beginning with "widget-".

comment:4 Changed 6 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:6 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.