Ticket #3698 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[patch] mcedit: codejump dialog jumps wrong.

Reported by: rimf Owned by: zaytsev
Priority: major Milestone: 4.8.19
Component: mcedit Version: 4.8.18
Keywords: codejump ctags etags Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

I create TAGS file with command:
$ find . -type f -name "*.[ch]" | ctags --c-kinds=+p --fields=+iaS --extra=+q -e -L-

My quick fix patch attached.

Attachments

Fix-mcedit-codejump-etags-filenames-parsing.patch (612 bytes) - added by rimf 3 months ago.

Change History

Changed 3 months ago by rimf

comment:1 Changed 3 months ago by zaytsev

  • Owner set to zaytsev
  • Cc andrew_b added
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.19

Branch: 3698_etags_codejump
Changeset: 224f53518e75ec1736a6617257580f495abc1154

Roman, thanks for the clean patch! How about writing some tests for the parser ;-) ? I can understand if that's too much for you.

Andrew, could you please approve? I've investigated what caused the problem (see commit message) and it looks legit.

comment:2 Changed 3 months ago by rimf

Thank you. Now I can do only reports on bugs.

comment:3 Changed 3 months ago by andrew_b

  • Cc andrew_b removed
  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 3 months ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [85a28f11aeec9e847a6e503754ab8a112bab99c0]. Thank you!

comment:5 Changed 3 months ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.