Ticket #3661 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

wrong handling of mouse clicks in long listing mode

Reported by: seray Owned by: andrew_b
Priority: major Milestone: 4.8.18
Component: mc-core Version: 4.8.17
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

This occurs if the left panel is in long listing mode and the right panel is in full listing mode:
When the left panel is active and you click on the right side of the panel, the click event is directed to the (inactive) right panel instead of the (active) left panel.

This occurs if the right panel is in long listing mode:
When the left panel is active and you click on the left panel, the click event is always directed to the (inactive) right panel. It's impossible to click anything on the left panel, if the right panel is in long listing mode.

Also reported here:
https://github.com/MidnightCommander/mc/issues/105

PR:
https://github.com/MidnightCommander/mc/pull/106

Change History

comment:1 Changed 10 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.18

Thanks! I took the main idea from your patch and implemented it in some different way. Also I split the patch in several commits.

Branch: 3661_panel_mouse_click
Initial changeset:81700586727fa2bfa266c55114659a4499128477

Please review.

comment:2 Changed 10 months ago by seray

Looks good, thank you.

comment:3 Changed 10 months ago by andrew_b

  • Votes for changeset set to seray andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 10 months ago by andrew_b

Merged to master: [aa79525bb8fff418ee76cb60bb0b1bbbbbcab02b].

git log --pretty=oneline 5848342..aa79525

comment:5 Changed 10 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from seray andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:6 Changed 10 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.