Ticket #3641 (closed task: fixed)

Opened 10 months ago

Last modified 5 months ago

Prepare for release mc-4.8.18

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.8.18
Component: adm Version: master
Keywords: Cc: egmont
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description


Attachments

mc-3641-cleanup-Wconditional-uninitialized-at-input_complete.patch (1.1 KB) - added by and 9 months ago.
mc-3641-cleanup-compile-warning-for-mc_search.patch (1.4 KB) - added by and 9 months ago.
mc-3641-mcedit-syntax-associate-node-executables-with-JavaScript.patch (798 bytes) - added by mooffie 7 months ago.
mc-3641-cleanup-compile-warning-background_c.patch (3.1 KB) - added by and 7 months ago.
mc-3641-cleanup-compile-warning-glob_c.patch (831 bytes) - added by and 7 months ago.
mc-3641-cleanup-compile-warning-unused_macro.patch (10.0 KB) - added by and 7 months ago.
mc-3641-cleanup-paths_c.patch (3.2 KB) - added by mooffie 6 months ago.
mc-3641-paths.c-reduce-scope-of-homedir-var.patch (1.3 KB) - added by mooffie 6 months ago.
(See commit message. This is a followup to my previous patch.)
mc-3641-cleanup-Wformat-signedness-common_c.patch (1.1 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-editdraw_c.patch (3.4 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-file_c.patch (1.2 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-find_c.patch (2.6 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-ftpfs_c.patch (1.1 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-hex_c.patch (1.2 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-info_c.patch (3.1 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-midnight_c.patch (1.7 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-path_c.patch (1.0 KB) - added by and 5 months ago.
mc-3641-cleanup-Wformat-signedness-serialize_c.patch (4.5 KB) - added by and 5 months ago.
mc-3641-cleanup-Wunsafe-loop-optimizations.patch (1.1 KB) - added by and 5 months ago.
mc-3641-cleanup-no-attribute-noreturn-utilunix.c.patch (765 bytes) - added by and 5 months ago.
mc-3641-cleanup-no-attribute-noreturn-utilvfs.c.patch (1005 bytes) - added by and 5 months ago.
mc-3641-cleanup-unreachable-code-warning-utilunix_c.patch (930 bytes) - added by and 5 months ago.

Change History

comment:1 Changed 10 months ago by egmont

  • Cc egmont added

comment:2 Changed 9 months ago by andrew_b

Last edited 8 months ago by andrew_b (previous) (diff)

comment:3 Changed 9 months ago by andrew_b

mc-3641-cleanup-Wconditional-uninitialized-at-input_complete.patch​: applied.

comment:4 Changed 9 months ago by andrew_b

mc-3641-cleanup-compile-warning-for-mc_search.patch: applied.

comment:5 Changed 9 months ago by andrew_b

  • Blocking 3652 added

(In #3652) Applied with some modifications in 3641_cleanup branch.

comment:6 Changed 8 months ago by andrew_b

  • Branch state changed from no branch to on review

comment:7 follow-up: ↓ 8 Changed 7 months ago by mooffie

Hi Andrew!

I'm attaching a minor patch. Node.js is quite a buzz nowadays.

(I needed a ruse to chime in! You're doing a terrific job. Thanks for fixing the "long panel listing" mouse bug. I'm sorry for being AWOL the last couple of months: a computer crash I'm still reeling from took its toll.)

comment:8 in reply to: ↑ 7 Changed 7 months ago by andrew_b

Replying to mooffie:

I'm attaching a minor patch. Node.js is quite a buzz nowadays.

Applied. Thanks!

Changed 7 months ago by and

comment:9 Changed 7 months ago by andrew_b

mc-3641-cleanup-compile-warning-glob_c.patch​: applied.
mc-3641-cleanup-compile-warning-unused_macro.patch​: applied.

comment:10 Changed 7 months ago by andrew_b

About mc-3641-cleanup-compile-warning-background_c.patch​.
On x86_64:

$ LC_ALL=C mc -V | tail -1
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

As you can see, the bitwidths of int and size_t are different. I'm not sure that change of type form int to size_t in the following case

write (parent_fd, &len, sizeof (len));

(write 4 bytes instead of 2) is correct.

Upd: sorry, 8 bytes instead of 4, of course.

Last edited 7 months ago by andrew_b (previous) (diff)

comment:11 Changed 7 months ago by andrew_b

  • Votes for changeset set to committed-master
  • Branch state changed from on review to merged

comment:12 Changed 7 months ago by andrew_b

  • Blocking 3652 removed

comment:13 Changed 7 months ago by andrew_b

Branch: 3641_cleanup
Initial changeset: 4ddcefc8df7fde92a26abb1b4effe9b91471b087

Changed 6 months ago by mooffie

comment:14 Changed 6 months ago by mooffie

(That last patch contains a commit message explaining it.)

Changed 6 months ago by mooffie

(See commit message. This is a followup to my previous patch.)

comment:15 Changed 5 months ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

mc-3641-cleanup-paths_c.patch​: applied.
mc-3641-paths.c-reduce-scope-of-homedir-var.patch: applied.

Merged to master: [74dda7352ed0590d18bda30c34b9e895bebeb205].

git log --pretty=oneline 834c09a..74dda73
Last edited 5 months ago by andrew_b (previous) (diff)

comment:16 Changed 5 months ago by andrew_b

  • Status changed from closed to reopened
  • Resolution fixed deleted

Changed 5 months ago by and

Changed 5 months ago by and

Changed 5 months ago by and

Changed 5 months ago by and

Changed 5 months ago by and

comment:17 Changed 5 months ago by zaytsev

Created #3693 for further cleanup patches.

comment:18 Changed 5 months ago by andrew_b

mc-3641-cleanup-Wformat-signedness-common_c.patch​
mc-3641-cleanup-Wformat-signedness-editdraw_c.patch
mc-3641-cleanup-Wformat-signedness-file_c.patch
mc-3641-cleanup-Wformat-signedness-find_c.patch​
mc-3641-cleanup-Wformat-signedness-ftpfs_c.patch
mc-3641-cleanup-Wformat-signedness-hex_c.patch​
mc-3641-cleanup-Wformat-signedness-info_c.patch
mc-3641-cleanup-Wformat-signedness-midnight_c.patch
mc-3641-cleanup-Wformat-signedness-path_c.patch​
mc-3641-cleanup-Wformat-signedness-serialize_c.patch
mc-3641-cleanup-Wunsafe-loop-optimizations.patch​
mc-3641-cleanup-no-attribute-noreturn-utilunix.c.patch
mc-3641-cleanup-no-attribute-noreturn-utilvfs.c.patch
mc-3641-cleanup-unreachable-code-warning-utilunix_c.patch

were copied to #3693.

Last edited 5 months ago by andrew_b (previous) (diff)

comment:19 Changed 5 months ago by zaytsev

download PO-translations from Transifex.net

done

store translations in git repo

done

download the hint translations from Transifex.net

done

store translations in git repo

done

create new NEWS wiki page for next version

done (wiki:NEWS-4.8.19)

add content of current NEWS wiki page to the doc/NEWS

done

create new tag in git

done; not pushed yet

new version in Trac

done

new milestone in Trac

done

create tar.(bz2|xz) package files

done

make checksums for archives

done

upload source packages and checksums to the special upload area

done

developers should download tarballs, verify checksums, compile and install locally; if everything is ok, then developers vote for the ticket

...

comment:20 Changed 5 months ago by zaytsev

  • Status changed from reopened to accepted
  • Owner set to zaytsev
  • Votes for changeset committed-master deleted
  • Branch state changed from merged to approved

comment:21 Changed 5 months ago by andrew_b

  • Votes for changeset set to andrew_b

comment:22 Changed 5 months ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

upload source packages and checksums

done

run command: ...

done

update Wiki start page with latest release number

done

write an announcement

done

close current milestone

done

create new ticket (type=task, component=adm) for the next release

done; #3693

close ticket for release

done

comment:23 Changed 5 months ago by zaytsev

  • Status changed from testing to closed

comment:24 Changed 5 months ago by zaytsev

  • Milestone changed from 4.8.19 to 4.8.18
Note: See TracTickets for help on using tickets.