Ticket #3620 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

syntax error in patchfs.in

Reported by: zazaho Owned by: andrew_b
Priority: blocker Milestone: 4.8.17
Component: mc-vfs Version: 4.8.16
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Attachments

mc-syntax-error.patch (762 bytes) - added by andrew_b 3 years ago.

Change History

Changed 3 years ago by andrew_b

comment:1 Changed 3 years ago by andrew_b

  • Priority changed from major to blocker
  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review

Branch: 3620_patchfs_syntax_error
changeset:48cfd3b28d0837ae67aacf7952ac4740423bac0d

comment:2 Changed 3 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:4 Changed 3 years ago by andrew_b

  • Status changed from testing to closed

comment:5 Changed 3 years ago by zaytsev-work

This was broken in a bad merge here: [8fc0e1d76dbb9fe6606e444eae9328f937a49d67].

From GitHub:

What I really feel bad about is that both problems could have been avoided if we had at least some very basic tests both for FISH, which is now basically unmaintainable, because one can't change a single letter there without fear of breaking everything, and patchfs, where a stupid syntax mistake could have been avoided if the syntax was checked.

Now, if we simply commit the patches and close the tickets, exactly the same will happen again and again. Since nobody is testing master, and we don't have enough resources to test it properly, every next release will keep bringing such surprises.

See also my comments in #3611, can we reopen this ticket to add a simple autotools test to make check that tests whether the syntax of the Perl files is correct?

comment:6 Changed 3 years ago by zaytsev

Created #3636 regarding the tests.

Note: See TracTickets for help on using tickets.