Ticket #3549 (closed defect: invalid)

Opened 7 years ago

Last modified 7 years ago

View find results doesn't jump to match line if file is too short to scroll page

Reported by: wwp Owned by:
Priority: minor Milestone:
Component: mcview Version: 4.8.14
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

Viewing the search result in a file using the internal viewer doesn't jump to matched line IF the file is too short to feed the viewer page.

For instance, have a 20-line text file that contains the word FOO at line 10.
Make a search that match this file.
Press F3 to view the match in this file.
The viewer will show the file, and the line 1 of the page will show the file's line 1 instead of showing line 10.

This is particularly uncomfortable since you don't know where to look to find the match, visually and have to read the whole page for find the match (and there is no highlighting! but that's another story).

This only happen if the file is too short to be scrolled so that the matched line comes to line 1 of the viewer's page.

This has been introduced with mc 4.8.14. Before, the viewer was able to scroll beyong EOF in order to show the match at top of page.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to invalid
  • Milestone Future Releases deleted

What about use search before create ticket?
This is fixed as #3530.

comment:2 Changed 7 years ago by wwp

Andrew, you're definitly right, I completely failed this morning. Failed first during testing since my make-install failed without me seeing it and I ran the test using mc 4.8.14.. noob. Then, seeing the bug still "present", I ran a search here upon open tickets only. That's a kind of double fail, but now that I'm running 4.8.15 and see that the match is being highlight (you fixed it that way, why not, it's good enough to see the match!), I'm definitely happy :-). Sorry for the noise and thanks for the fix and comment!

Note: See TracTickets for help on using tickets.