Ticket #3453 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 weeks ago

Find file results dialog title patch

Reported by: Miven Owned by: andrew_b
Priority: minor Milestone: 4.8.22
Component: mc-core Version: master
Keywords: find file results dialog Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Find File (M-?) works great. However, I often have more than 1 mc running on side by side workspaces grepping in the same huge directory for related things. When I get results from 2 side by side searches, there is no indication in the results dialog what the results were for. Sometimes these searches take quite a while and I cannot recall which one was for what by the time they complete.

I have a patch here that adds the Find pattern and Contents pattern (if used) to the results dialog title, so that you can see exactly what you were grepping for, after a lengthy search is completed.

Attachments

patch01-find.c-find-file-title-content.diff (1.4 KB) - added by Miven 3 years ago.
Find file search results dialog patch

Change History

Changed 3 years ago by Miven

Find file search results dialog patch

comment:1 Changed 3 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.17

comment:2 Changed 2 years ago by zaytsev

  • Milestone changed from 4.8.17 to 4.8.18

comment:3 Changed 2 years ago by zaytsev

  • Milestone changed from 4.8.18 to 4.8.19

comment:4 Changed 10 months ago by zaytsev

  • Milestone changed from 4.8.20 to 4.8.21

comment:5 Changed 4 months ago by zaytsev

  • Milestone changed from 4.8.21 to 4.8.22

comment:6 Changed 4 weeks ago by andrew_b

  • Owner changed from zaytsev to andrew_b
  • Component changed from mc-search to mc-core
  • Branch state changed from no branch to on review

Branch: 3453_find_results_title
changeset:67c6496031c23367e4db8caa4e3677058cdb01fc

comment:7 follow-up: ↓ 8 Changed 3 weeks ago by andrew_b

  • Branch state changed from on review to on rework

Rework is required to support dialog resize.

comment:8 in reply to: ↑ 7 Changed 3 weeks ago by andrew_b

  • Branch state changed from on rework to on review

Replying to andrew_b:

Rework is required to support dialog resize.

Done.

Branch: 3453_find_results_title
Initial changeset:a38c7f19e9598d4b68183382c43f8a52f40a2a4a

comment:9 Changed 2 weeks ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:10 Changed 2 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [202b80a2eb3cda5bb319276e9c3471a52f96f42d].

git log --pretty=oneline faa893b..202b80a

comment:11 Changed 2 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.