Ticket #3261 (closed defect: fixed)
mcview hex mode: CJK overflow
| Reported by: | egmont | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.14 |
| Component: | mcview | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
mcview, hex mode, in a fully UTF-8 environment, with a file containing double wide (CJK) characters.
At certain terminal widths (including the default 80), if the last byte of a line begins a CJK character then the corresponding glyps is drawn in the last column, so it's replaced by a replacement symbol.
The default layout should, at all possible terminal widths, have an extra last character column that is empty normally, but allows room for a CJK to overflow here.
Attachments
Change History
comment:3 Changed 9 years ago by egmont
Friendly ping... a patch has been attached for 6 months now. Could you please take a look? It would be nice to release this fix along with the mcviewer rewrite.
comment:4 Changed 9 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.14
Thanks!
Branch: 3261_hexedit_cjk_overflow
changeset:10c938451d66ac9df641a5793e989ebd41e9ba14
comment:5 Changed 9 years ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:6 Changed 9 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [10c938451d66ac9df641a5793e989ebd41e9ba14].
(Alternatively... I believe all CJK chars are 3 bytes at least (to be verified), and if it's wrapped in the problematic way (1 byte at the end of a line and 2 bytes in the next line), we can display the glyph at the beginning of the new line. But this might easily be misleading, and harder to implement.)