mcedit - Record and playback macro works first few times only

[nkirk01]

Open a utf-8 text file in mcedit from mc, record a macro to change some text on each line of the file, then run the macro okay for perhaps 4 times, then the macro no longer works correctly, starts deleting characters in the file sequentially instead, cannot exit macro run mode.

Debian Lenny system - i386 - locale is en_US - with KDE4
Running mc in a KDE konsole.

Using todays Git repo version 4.6.2 (April 7, 2009) which I built from the Git repo sources with libslang2.

GNU Midnight Commander 4.6.2
Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With support for X11 events
With internationalization support
Data types: char 8 int 32 long 32 void * 32 off_t 64 ecs_char 8

Thanks.

[sxmboer]

The problem with the macros was that the keystroke CTRL-R was saved along with the macro, causing it to restart recording a macro.

This patch breaks the behavior of the macro saving when the user does that through the menu. So somewhere a conditional needs to be added, but I don't know where or what.

[sxmboer]

This patch obsoletes the previous patch to editcmd.
This patch looks for the keyboard command within the macro and deletes it if it is present. This writes the correct macro regardless of using the keyboard (CTRL-R) to stop recording or the menu.

[styx]

Replying to sxmboer:

I think you need to read this:
​http://www.midnight-commander.org/wiki/WorkingGuideLines

When you have finished something, you are just setting review tag.

Thank you work.

[styx]

Replying to sxmboer:

• Thank you for your work

[iNode]

There is no branch to review.

[sxmboer]

Retested in 4.7.0pre4.
Macro recording is now completely broken.

[angel_il]

Replying to sxmboer:

Retested in 4.7.0pre4.
Macro recording is now completely broken.

i want fix it, but can you show me what's wrong?
how to reproduce this, step by step?...

[angel_il]

Nathan Kirk wrote:

Sure, to reproduce the issue:
- from Midnight Commander press F4 to edit a file
- press Ctrl-R to start recording
- add some text, move around
- press Ctrl-R to stop recording and save the macro as key: "a". ("a" is arbitrary)
- Then, to replay the macro, press "Ctrl-A a" for the first replay.
- Continue pressing "Ctrl-A a" to keep replaying the same macro
After the first few times the macro fails to complete normally, and will eventually lock up the editor session.

Hope this helps.

[zaytsev]

Seems to be broken on latest stable:

​https://bugs.launchpad.net/ubuntu/+source/mc/+bug/314614

[zaytsev]

With Ubuntu 8.10 Release: 8.10, and Kubuntu 8.10 in terminal mode, 
mcedit freezes when macro's are used.

When i use Cntr-R (start macro) a macro is recorded, and with 
Cntr-R (close macro) and then A it's saved.

With Cntr-A A it should repeat the macro that was previously 
recorded in A.

With Cntr-A A (execute macro A) mcedit freezes after executing
it 2 or 3 times.

[ddanila]

FYI: Just reproduced on 4.7.5-33-g2e85893

[angel_il]

branch: DEV_editor_macros_fix
changeset: ​http://www.midnight-commander.org/changeset/DEV_editor_macros_fix

[angel_il]

branch: 323_editor_macros
changeset: ​http://www.midnight-commander.org/changeset/323_editor_macros

please review

[angel_il]

man

[angel_il]

Merged: 0cfbe19d96c29c832ae0ca0ee76d1618d71a45b6

[andrew_b]

#2512 fixes problem with interactive scripts.