Ticket #3184 (closed enhancement: fixed)

Opened 11 years ago

Last modified 11 years ago

Minor skin cleanups

Reported by: egmont Owned by: andrew_b
Priority: trivial Milestone: 4.8.12
Component: mc-skin Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

I attach a syntax cleanup to the skin files. The patch goes on top of #3183.

  • Consistent indentation: All skins use now 4 spaces (the default of mcedit). This makes it easier to copy-paste sections from one skin to another, while maintaining consistency.
  • Spaces around the '=' sign. Currently it's inconsistent. I believe the version with spaces is more readable, especially around double line characters.
  • The order of the sections is made consistent across all skins.
  • In [menu], swapping the order of "menusel" and "menuhot" makes the order consistent with the [dialog] and [error] sections.
  • I added the missing "helptitle" to sand256 (my skin). This is the only functional change.

Attachments

mc-3184-skin-cleanup.patch​ (105.7 KB) - added by egmont 11 years ago.

Change History

Changed 11 years ago by egmont

comment:1 Changed 11 years ago by egmont

Updated: added helptitle to all other skins that were missing it.

comment:2 Changed 11 years ago by andrew_b

  • Blocked By 3183 added

comment:3 Changed 11 years ago by andrew_b

  • Blocking 3180 added

comment:4 Changed 11 years ago by andrew_b

  • Blocked By 3183 removed

comment:5 Changed 11 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.12

comment:6 Changed 11 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from no branch to merged

Thanks! Applied as [38a6c44091bb53ba64b7fece49e38885d076b77e].

comment:7 Changed 11 years ago by andrew_b

  • Status changed from testing to closed
  • Blocking 3180 removed

comment:8 Changed 11 years ago by andrew_b

  • Votes for changeset set to committed-master
Note: See TracTickets for help on using tickets.