Ticket #3183 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

diffviewer line drawing fix

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.8.12
Component: mcdiff Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

The "topmiddle" and "bottommiddle" characters are defined incorrectly in many skins. This is because the correct definition wouldn't work with Slang build. The only place these characters are used is the diffviewer if either the +/- signs or the line numbers are shown, enabled by pressing S or L. The correct definition of these characters currently show up as 'v' and 'w' characters.

The attached patch makes the diffviewer use tty_print_alt_char() as it is being used in other parts of the code, and hence it fixes the bug. It also fixes the skin definitions.

Attachments

mc-3183-diffviewer-lines.patch (10.8 KB) - added by egmont 4 years ago.

Change History

Changed 4 years ago by egmont

comment:1 Changed 4 years ago by andrew_b

  • Blocking 3184 added

comment:2 Changed 4 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.12

Thanks!

Branch:3183_diffviewer_lines
changeset:dd60eb6c683abc841e579740facfa7cd1368edb7

comment:3 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from no branch to approved

comment:4 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
Last edited 4 years ago by andrew_b (previous) (diff)

comment:5 Changed 4 years ago by andrew_b

  • Status changed from testing to closed

comment:6 Changed 4 years ago by andrew_b

  • Blocking 3184 removed
Note: See TracTickets for help on using tickets.