Ticket #3178 (closed defect: fixed)
commandlinemark not updated on skin change
| Reported by: | egmont | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | trivial | Milestone: | 4.8.12 |
| Component: | mc-skin | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Leftover bug from #2165:
When changing the skin while mc is running, commandlinemark color (if a part of the command line is highlighted with Shift+Left or Shift+Right) is not updated.
Test:
- Start "mc -S gotar", type something in the command line, highlight with Shift+Left.
- Start "mc -S default", change the skin to gotar, type something in the command line, highlight with Shift+Left.
The highlighted parts have different colors in these two cases.
Attachments
Change History
comment:1 Changed 11 years ago by egmont
Please see the attached fix.
The patch from #2165 changed the way dialogs keep track of their colors: instead of remembering the actual colors, now they only store a pointer to some global data. This way it's much easier to update them.
The current patch brings the same approach to input fields.
comment:2 Changed 11 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.12
Thanks for the patch. I've applied it with small modifications:
- move command_colors variable to src/filemanager/command.c
- create separated function command_set_default_colors ();
- call command_set_default_colors() only if command line is created (MC is run as mc, not as mcedit, mcview, mcdiff).
Branch: 3178_commandlinemark_update
changeset:b28ee2bf4353e4f51451d96187a40e233c7f2c3f
comment:4 Changed 11 years ago by slavazanko
- Votes for changeset set to slavazanko
- Branch state changed from on review to approved
comment:5 Changed 11 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [976c18557ee8348292200009f8acc5057cf7f0e9].
