Subshell not working under Zsh

[IceMan]

Subshell not working when MC started from Zsh.

GNU Midnight Commander 4.8.11-88-g5f94d51
Built with GLib 2.32.4
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

To reproduce problem you can try:

su - $(whoami) -s /bin/bash -c /usr/bin/mc # works
su - $(whoami) -s /bin/zsh -c /usr/bin/mc # sleeps more than 5 secs at startup, then starts but subshell not working

[egmont]

Indeed. It broke at some point after 4.8.11.

An easier way of reproducing: SHELL=/usr/bin/zsh /usr/bin/mc

It sleeps for 10 seconds, as per src/subshell.c feed_subshell()'s wtime.

[egmont]

git bisect says:
75073307b9f8d500e4b04318f7a78e5b5bf2b884 is the first bad commit
Ticket #3125: don't override precmd on Zsh[...]

[egmont]

fix

[egmont]

Please see the attached fix.
I'm not sure the result is exactly what's intended, but it seems to work, and I took the idea from ​https://git.gnome.org/browse/vte/tree/src/vte.sh?h=vte-0-36 .

[andrew_b]

Branch: 3177_zsh_long_start
changeset:c96a73da49ec86a5d29ffedec315411aaab7d173

[andrew_b]

Merged to master: [c96a73da49ec86a5d29ffedec315411aaab7d173].