Ticket #3167 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

minor issues with copyright lines

Reported by: egmont Owned by: andrew_b
Priority: trivial Milestone: 4.8.12
Component: documentation Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Three problems:

  1. Changeset 25bc34a4b5470fad1cd1172799c1bc856d62aabf (merging branch 3113_cleanup) introduces a mistake in lib/strutil/xstrtol.c: "Free Software" got dropped. The file now contains:
   Copyright (C) 1995-2014
   Foundation, Inc.
  1. Most files in MC say "The Free Software Foundation, Inc.", although the "The" is not part of their name. The very top of the COPYING file even says "Copyright © 2007 Free Software Foundation, Inc." without "The". I believe that "The" should be removed from all the files. (Note: I'm not a native English speaker.)
  1. Many files contain an obsolete address of FSF (59 Temple Place...). Their current postal address is 51 Franklin Street... Following the wording of GPL 3 it might be a good idea to remove the postal address and replace with their URL. (Idea from https://bugzilla.gnome.org/show_bug.cgi?id=721455)

Change History

comment:1 in reply to: ↑ description ; follow-up: ↓ 2 Changed 3 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.12

Replying to egmont:

Three problems:

  1. a mistake in lib/strutil/xstrtol.c: "Free Software" got dropped.

Fixed. Thanks!

  1. Most files in MC say "The Free Software Foundation, Inc.", although the "The" is not part of their name.

Fixed.

  1. Many files contain an obsolete address of FSF (59 Temple Place...).

Can't find that files in repo. Such files are in the intl/ subdirectory which is a part of gettext.

Their current postal address is 51 Franklin Street... Following the wording of GPL 3 it might be a good idea to remove the postal address and replace with their URL. (Idea from https://bugzilla.gnome.org/show_bug.cgi?id=721455)

Fixed.

Branch: 3167_copyright
Initial changeset:6152f07de5917f9a68a7b347394460374433bb14

comment:2 in reply to: ↑ 1 Changed 3 years ago by egmont

Can't find that files in repo. Such files are in the intl/ subdirectory which is a part of gettext.

Indeed, you're right.

Thanks for the fix!

comment:3 Changed 3 years ago by slavazanko

  • Votes for changeset set to slavazanko
  • Branch state changed from on review to approved

comment:4 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [5f94d51fab5572ded65208629ef4730fead4a712].

git log --pretty=oneline 262feea..5f94d51

comment:5 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.