Ticket #3154 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

nicedark skin looks bad on black-on-white terminals

Reported by: egmont Owned by:
Priority: trivial Milestone: 4.8.12
Component: mc-skin Version: 4.8.11
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

If your terminal has white background and black foreground, the "nicedark" skin doesn't look good. While most of mc's background is explicitly set to black, the dialogs (e.g. file copy, command history etc.) have an implicit white background (the terminal's default background color). This is because the skin file uses the unknown keyword "darkgray".

I guess the author's intent was "black". This way it'd look the same on black-on-white and white-on-black terminals (except of course the command line).

Attachments

mc-3154-nicedark.patch (1.2 KB) - added by egmont 3 years ago.

Change History

comment:1 follow-up: ↓ 2 Changed 3 years ago by ossi

dark gray is "light black" per vga color palette.
maybe it should be grey, not gray? many systems accept both as synonymous (which they are), but maybe not mc.

comment:2 in reply to: ↑ 1 Changed 3 years ago by andrew_b

Replying to ossi:

maybe it should be grey, not gray?

slang uses "gray" only. mc too.

comment:3 Changed 3 years ago by egmont

If you change it to "gray" then the its look on white-on-black terminals (where the theme is likely being used currently) changes. The text over that gray background is quite hard to read. This clearly wasn't the author's intention, as he would have noticed it on his terminal.

I find it much more likely that he intended black background, and didn't notice the invalid keyword because he only tested on white-on-black. Changing to "black" is the fix that does not change (read: does not break :)) the look on white-on-black terminals, and makes the faulty case look just as great as the good case looks now.

Changed 3 years ago by egmont

comment:4 follow-up: ↓ 5 Changed 3 years ago by egmont

Could you please apply the patch? It fixes the look of this skin on black-on-white terminals, and doesn't change the look on white-on-black ones.

Now that we have a user-friendly skin selector, it's likely that more people will explore skins, and it becomes more important that the ones we ship actually look nice and usable, rather than broken.

comment:5 in reply to: ↑ 4 Changed 3 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Milestone changed from Future Releases to 4.8.12

Replying to egmont:

Could you please apply the patch?

Applied: [9bbc51098ed53c6e4b83b8920e81463cc1521e29].
Thanks!

Note: See TracTickets for help on using tickets.