Ticket #3152 (closed enhancement: fixed)
Display bits's Select button is unconventional
| Reported by: | egmont | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | trivial | Milestone: | 4.8.12 |
| Component: | mc-core | Version: | 4.8.11 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Options -> Display bits looks like:
Input / display codepage: UTF-8 [ Select ]
whereas UTF-8 is a non-clickable label reflecting the actual value, and Select is the button that lets you choose a different value.
This is very unusual, does not mimic at all how dropdown lists (html's <select><option>, and similar ones in graphical toolkits) work. A better design would be:
Input / display codepage: [ UTF-8 ]
i.e. the currently active value is the button's label.
mc's Advanced chown also works this latter way: the current value (username or group) is the button that you can click on. I'm also following this design in my work in progress patch in #2165.
Change History
comment:1 Changed 11 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.12
comment:2 Changed 11 years ago by slavazanko
- Votes for changeset set to slavazanko
- Branch state changed from on review to approved
TODO: to update *.po after merge because was removed line with N_("&Select").
comment:3 Changed 11 years ago by egmont
(po files are often updated anyways, and a stale entry doesn't cause any problem. You can update of course, but it's not important at all.)
comment:4 Changed 11 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [f1953f368dfc732f6feab40774963e00af315368].
Branch: 3152_display_bits
changeset:61d60f6dc80e30a7075ea26dc5eee2d9236028dd