Ticket #3149 (closed defect: fixed)
"compute totals" unnecessarily done for moves
| Reported by: | ossi | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.21 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | egmont, mooffie | |
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
mc will compute the totals for a directory move as if it was a copy. this is obviously tremendously pointless if the move can be done cleanly with a single rename() call, and an annoying waste of time if the directory has a deep substructure.
i presume this is the result of #2075.
consequently the computation should be aware of the operation it targets.
related ticket: #20
Change History
comment:2 Changed 10 years ago by andrew_b
Ticket #3395 has been marked as a duplicate of this ticket.
comment:3 Changed 8 years ago by andrew_b
Ticket #3653 has been marked as a duplicate of this ticket.
comment:4 Changed 8 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
Branch: 3149_move_compute_total
Initial changeset:6e86e4873a8498bc4ccfbdfeb93155eeaf18e502
comment:5 Changed 8 years ago by andrew_b
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.18
comment:9 Changed 7 years ago by zaytsev
- Cc egmont, mooffie added
I'm completely overloaded @ $DAYJOB, so no chance I can get to it anytime soon :-/ Maybe egmont or mooffie? Or even the reporter?
comment:12 Changed 7 years ago by andrew_b
- Branch state changed from on rework to on review
Branch: 3149_move_compute_total
Initial changeset:6e86e4873a8498bc4ccfbdfeb93155eeaf18e502
Please review.
comment:13 Changed 7 years ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:14 Changed 7 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [e4d9a817a7c8a92d6be6265832ed0196377d9669].
git log --pretty=oneline 1782809..e4d9a81
Ticket #3185 has been marked as a duplicate of this ticket.